Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form Submission - UseMutation Refactor - 2 retries; style: secondary button - pipe - changed to the proper color #746

Merged
merged 12 commits into from
Jun 25, 2024

Conversation

shindigira
Copy link
Contributor

@shindigira shindigira commented Jun 21, 2024

closes #507
closes #463
closes #763

Changes

  • enhancement: Adds a react-query useMutation wrapper around many of the form submissions that adds a retry to combat the 503/504 issues on deployment
  • style: secondary button - right icon vertical bar - changed to the proper color

Screenshot - secondary button - right icon vertical bar

Before After
Screenshot 2024-06-24 at 4 49 58 PM Screenshot 2024-06-24 at 4 48 59 PM

@shindigira shindigira marked this pull request as draft June 21, 2024 15:51
@shindigira shindigira marked this pull request as ready for review June 21, 2024 20:30
@shindigira shindigira changed the title WIP: Form Submission - UseMutation Refactor Form Submission - UseMutation Refactor, 2 retries Jun 21, 2024
Copy link
Contributor

@billhimmelsbach billhimmelsbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heyo! I get errors when using this branch on the verify warnings step:

Screenshot 2024-06-24 at 11 36 25 AM

@shindigira
Copy link
Contributor Author

Heyo! I get errors when using this branch on the verify warnings step:

Screenshot 2024-06-24 at 11 36 25 AM

Thanks for finding the issue. This should fix the issue.

Copy link
Collaborator

@meissadia meissadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @shindigira! I've run through a few Filing iterations and I'm able to go end-to-end with no errors or hiccups. LGTM 👍🏾

@shindigira
Copy link
Contributor Author

Thanks for the fix @shindigira! I've run through a few Filing iterations and I'm able to go end-to-end with no errors or hiccups. LGTM 👍🏾

I think you meant to approve 😸

@shindigira shindigira changed the title Form Submission - UseMutation Refactor, 2 retries Form Submission - UseMutation Refactor - 2 retries; style: secondary button - pipe - changed to the proper color Jun 25, 2024
@shindigira shindigira merged commit e8dc535 into main Jun 25, 2024
4 checks passed
@shindigira shindigira deleted the 507-463-usemutation-refactor branch June 25, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants