-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Filing] Upload - Adjust when we render the 'Unable to continue' messaging #767
Conversation
|
407ec93
to
a730b24
Compare
2869fb3
to
c7cab4b
Compare
@natalia-fitzgerald Updated demo videos to show current functionality. |
Pull Request is not mergeable
Hey @natalia-fitzgerald, mind taking a look at these changes in the videos above / on the preview site? |
@meissadia |
<Alert | ||
message='File upload and validation checks must be completed to save and continue' | ||
status='error' | ||
aria-live='polite' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added accessibility notice
Would you like a field level alert instead? |
@shindigira
|
…icate-status-message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Close #766
Changes
Demos
Scenario 1 - New upload
Scenario.1.-.New.upload.mov
Scenario 2 - Existing upload
Scenario.2.-.Existing.upload.mov
Scenario 3 - Error uploading
Scenario.3.-.Error.upload.mov
Scenario 4 - Ready to save and continue
Scenario.4.-.Save.and.continue.mov