Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filing] Upload - Adjust when we render the 'Unable to continue' messaging #767

Merged
merged 7 commits into from
Jul 8, 2024

Conversation

meissadia
Copy link
Collaborator

@meissadia meissadia commented Jun 25, 2024

Close #766

Changes

  • Moves the error Alert re: not being ready to save and continue down to the bottom of the page
    • Shows/hides this alert as demonstrated below

Demos

Scenario 1 - New upload

Scenario.1.-.New.upload.mov

Scenario 2 - Existing upload

Scenario.2.-.Existing.upload.mov

Scenario 3 - Error uploading

Scenario.3.-.Error.upload.mov

Scenario 4 - Ready to save and continue

Scenario.4.-.Save.and.continue.mov

@meissadia meissadia marked this pull request as draft June 25, 2024 19:47
@natalia-fitzgerald
Copy link

@meissadia

  • The error alert message for any time a user clicks the "Save and continue" button without completing the requirements for the step should be: "File upload and validation checks must be completed to save and continue."
  • This error alert should be positioned at the bottom of the page under "Go back" and "Save and continue"
  • In the example you show here the changes to the implementation would be to update the error alert text and move the error alert box to the bottom of the page as shown in the mock-up.

@meissadia meissadia force-pushed the upload__duplicate-status-message branch from 407ec93 to a730b24 Compare June 26, 2024 16:03
@meissadia meissadia marked this pull request as ready for review June 26, 2024 16:14
@meissadia meissadia changed the title [Filing] Upload - Only display one status Alert at a time [Filing] Upload - Adjust when we render the 'Unable to continue' messaging Jun 26, 2024
@meissadia meissadia force-pushed the upload__duplicate-status-message branch from 2869fb3 to c7cab4b Compare June 26, 2024 19:56
@meissadia
Copy link
Collaborator Author

@natalia-fitzgerald Updated demo videos to show current functionality.

@meissadia meissadia enabled auto-merge (squash) June 28, 2024 18:40
auto-merge was automatically disabled June 28, 2024 18:43

Pull Request is not mergeable

@meissadia meissadia enabled auto-merge (squash) June 30, 2024 16:46
@billhimmelsbach
Copy link
Contributor

Hey @natalia-fitzgerald, mind taking a look at these changes in the videos above / on the preview site?

@natalia-fitzgerald
Copy link

@meissadia
As a part of this PR will you add the alert to the Resolve errors and Review warnings pages? In order to create consistency across the alerts on all of these pages can you change the text to paragraph (instead of H4) and include a period? This is what we do on Resolve errors and Review warnings for this alert.

<Alert
message='File upload and validation checks must be completed to save and continue'
status='error'
aria-live='polite'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added accessibility notice

@shindigira
Copy link
Contributor

@meissadia As a part of this PR will you add the alert to the Resolve errors and Review warnings pages? In order to create consistency across the alerts on all of these pages can you change the text to paragraph (instead of H4) and include a period? This is what we do on Resolve errors and Review warnings for this alert.

Would you like a field level alert instead?

@natalia-fitzgerald
Copy link

natalia-fitzgerald commented Jul 2, 2024

@shindigira
For now let's keep the form-level alert (I did consider field-level but landed on form-level for visual prominence and because it does apply to the whole form...although typically a form-level alert would sit above, not below, the form). The styling should be standard paragraph style with a period at the end of the sentence.

  • Regular weight (400)
  • 16px
  • Avenir Next

Copy link
Collaborator

@ojbravo ojbravo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@meissadia meissadia merged commit 8b9481f into main Jul 8, 2024
4 checks passed
@meissadia meissadia deleted the upload__duplicate-status-message branch July 8, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Upload] Only show one status Alert
5 participants