-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: nginx.conf updated with url sources based on cfpb analytics whitelist #818
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you accidentally pushed things you don't want in this PR. Messaging you now.
59983e0
to
d97100e
Compare
Thank you for catching that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heyo @shindigira! Can you push this change up to the preview branch, so we can test it / confirm it with the analytics team before we move it to staging?
Updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heyo! So we confirmed this morning that things were working now, but if you take another peek at the issue, Paul just wants us to add these four domains:
"dap.digitalgov.gov",
"*.googleanalytics.com",
"*.google-analytics.com",
"*.googletagmanager.com",
We don't need all the new CSP additions from that example Paul gave us (like the font-src exceptions), we just need the 4 domains above in the same places they were in the example. Having said that, I might also keep the mouseflow.com
ones, just to save us a step when he implements it soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed with Paul that things are looking good, so this one is ready for staging. 🎉
closes #817
Changes
How to test this PR