-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
content(Upload): updated based on figma content updates after usability testing #837
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shindigira
Thanks for sharing these changes. I have a few content revisions that I have noted here.
Also, I would like to add the alerts at the bottom of the page for when a user tries to click "Continue to next step" without completing the requirements for the current step. It looks like you added this to the "Upload file" step but the styling is not correct. The text should be styled with paragraph text (16px, Regular). It is currently styled as an H4 in the code. I would also like to add these alerts to the Resolve error and Review warnings pages.
Images of the alerts that show up at the bottom of the page when a user tries to "Continue to the next step" without completing the requirements for the current step they are on.
@natalia-fitzgerald Updated. I deployed this and Omar's Resolve Errors content. The only change I have not put in is the bottom alert in Resolve Errors that is discussed above. However, the bottom alert in Upload has been updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shindigira
I noted one item that should be updated if it hasn't yet.
@natalia-fitzgerald Updated till this point. Will deploy to dev pub soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and Natalia approves 👍!
Dismissing this changes so it can be merged, with Natalia having given her approval in SBL Frontend.
…ty testing (#837) closes #836 - content(Upload): updated alert and buttons (e.g. 'Continue to next step') based on figma content updates after usability testing - Will deploy to dev pub -- compare the figma with what is deployed - Upload - warnings, errors, success csv's to see the updated messages [logic-errors_small.csv](https://github.com/user-attachments/files/16501790/logic-errors_small.csv) [logic-warnings_small.csv](https://github.com/user-attachments/files/16501791/logic-warnings_small.csv) [pass_123456789TESTBANK456_small.csv](https://github.com/user-attachments/files/16501792/pass_123456789TESTBANK456_small.csv)
closes #836
Changes
How To Test
logic-errors_small.csv
logic-warnings_small.csv
pass_123456789TESTBANK456_small.csv