Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated headings, button text, and playwright tests. #846

Merged
merged 9 commits into from
Aug 8, 2024

Conversation

ojbravo
Copy link
Collaborator

@ojbravo ojbravo commented Aug 6, 2024

Closes #838. All Playwright tests pass.

@ojbravo ojbravo enabled auto-merge (squash) August 6, 2024 12:11
billhimmelsbach
billhimmelsbach previously approved these changes Aug 8, 2024
Copy link
Contributor

@billhimmelsbach billhimmelsbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and it was approved by Natalia in SBL Frontend chat. 👍

billhimmelsbach
billhimmelsbach previously approved these changes Aug 8, 2024
Copy link
Contributor

@billhimmelsbach billhimmelsbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Natalia approved these change in our channel, and the code looks good. Thanks!

@natalia-fitzgerald
Copy link

I reviewed the changes on dev and everything looks good. The changes are approved.

Copy link

@natalia-fitzgerald natalia-fitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ojbravo
The changes look good to go. Later today I will send updated content for line 255 but I don't want this change to block merging this PR now. Thanks!

@billhimmelsbach billhimmelsbach merged commit c201181 into main Aug 8, 2024
4 checks passed
@billhimmelsbach billhimmelsbach deleted the 838-heading-button-text branch August 8, 2024 13:58
billhimmelsbach pushed a commit that referenced this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Update] Update Heading & Button Text
4 participants