generated from cfpb/open-source-project-template
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(content): mostly change submission to filing #883
Merged
billhimmelsbach
merged 6 commits into
main
from
882-change-submission-to-filing-usually
Aug 20, 2024
Merged
fix(content): mostly change submission to filing #883
billhimmelsbach
merged 6 commits into
main
from
882-change-submission-to-filing-usually
Aug 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billhimmelsbach
requested review from
meissadia,
shindigira and
ojbravo
as code owners
August 16, 2024 18:42
billhimmelsbach
commented
Aug 16, 2024
billhimmelsbach
commented
Aug 16, 2024
ojbravo
previously approved these changes
Aug 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything is working on dev.
ojbravo
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
billhimmelsbach
added a commit
that referenced
this pull request
Aug 20, 2024
We're making the name consistent across the website to a new name: "Small Business Lending Data Filing Platform." This also includes changing "submission" to "filing" in most contexts. - Small Business Lending Data Submission Platform -> Small Business Lending Filing Platform - index.html for title and meta info - App.tsx - BetaAndLegalNoice.tsx - Privacy notice - Point of contact - Complete user profile - Submission to Filing - FormErrorHeader in point of contact form validation - Review institution info - Sign and Submit - Post submission page (not implemented) - Filing Home - Point of contact - "platform" to "beta platform" when referring directly to the beta in the beta/legal notice - Remove "submission" from the report name and change hyphens to underscores Currently on the dev environment for review 1. Has the copy changed? 2. Does the site still work?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're making the name consistent across the website to a new name: "Small Business Lending Data Filing Platform." This also includes changing "submission" to "filing" in most contexts.
Changes
How to test this PR
Currently on the dev environment for review