Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(content): mostly change submission to filing #883

Merged
merged 6 commits into from
Aug 20, 2024

Conversation

billhimmelsbach
Copy link
Contributor

@billhimmelsbach billhimmelsbach commented Aug 16, 2024

We're making the name consistent across the website to a new name: "Small Business Lending Data Filing Platform." This also includes changing "submission" to "filing" in most contexts.

Changes

  • Small Business Lending Data Submission Platform -> Small Business Lending Filing Platform
    • index.html for title and meta info
    • App.tsx
    • BetaAndLegalNoice.tsx
    • Privacy notice
    • Point of contact
    • Complete user profile
  • Submission to Filing
    • FormErrorHeader in point of contact form validation
    • Review institution info
    • Sign and Submit
    • Post submission page (not implemented)
    • Filing Home
    • Point of contact
  • "platform" to "beta platform" when referring directly to the beta in the beta/legal notice
  • Remove "submission" from the report name and change hyphens to underscores

How to test this PR

Currently on the dev environment for review

  1. Has the copy changed?
  2. Does the site still work?

ojbravo
ojbravo previously approved these changes Aug 19, 2024
Copy link
Collaborator

@ojbravo ojbravo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is working on dev.

Copy link
Collaborator

@ojbravo ojbravo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@billhimmelsbach billhimmelsbach merged commit 896c941 into main Aug 20, 2024
4 checks passed
@billhimmelsbach billhimmelsbach deleted the 882-change-submission-to-filing-usually branch August 20, 2024 18:48
billhimmelsbach added a commit that referenced this pull request Aug 20, 2024
We're making the name consistent across the website to a new name:
"Small Business Lending Data Filing Platform." This also includes
changing "submission" to "filing" in most contexts.

- Small Business Lending Data Submission Platform -> Small Business
Lending Filing Platform
  - index.html for title and meta info
  - App.tsx
  - BetaAndLegalNoice.tsx
  - Privacy notice
  - Point of contact
  - Complete user profile
- Submission to Filing
  - FormErrorHeader in point of contact form validation
  - Review institution info
  - Sign and Submit
  - Post submission page (not implemented)
  - Filing Home
  - Point of contact
- "platform" to "beta platform" when referring directly to the beta in
the beta/legal notice
- Remove "submission" from the report name and change hyphens to
underscores

Currently on the dev environment for review

1. Has the copy changed?
2. Does the site still work?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants