Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Nav] Flyout Responsive Menu #935

Merged
merged 18 commits into from
Oct 29, 2024
Merged

[Nav] Flyout Responsive Menu #935

merged 18 commits into from
Oct 29, 2024

Conversation

ojbravo
Copy link
Collaborator

@ojbravo ojbravo commented Sep 17, 2024 •
edited by meissadia
Loading

Mobile menu is working. Functionality matches cfpb.gov.

Closes #918.

Prerequisites:

@ojbravo ojbravo self-assigned this Sep 17, 2024
@ojbravo ojbravo changed the title MVP [Nav] Flyout Responsive Menu Sep 17, 2024
@billhimmelsbach
Copy link
Contributor

Heyo @ojbravo! This one is waiting on Natalia's seal of approval right?

@ojbravo ojbravo marked this pull request as draft September 20, 2024 20:28
@shindigira
Copy link
Contributor

@ojbravo This is still in draft. Is it ready for a review?

@ojbravo ojbravo marked this pull request as ready for review September 27, 2024 22:51
@billhimmelsbach
Copy link
Contributor

Getting this prepped for deployment too.

billhimmelsbach
billhimmelsbach reviewed Oct 17, 2024
View reviewed changes
Copy link
Contributor

@billhimmelsbach billhimmelsbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A build error on this one, maybe due to the pinned design system react dependency? I'll take a look at it after the next meeting.

@meissadia
Copy link
Collaborator

meissadia commented Oct 17, 2024 •
edited
Loading

A build error on this one, maybe due to the pinned design system react dependency? I'll take a look at it after the next meeting.

@billhimmelsbach I too am getting a crash when previewing the build locally. Trying to determine why.

billhimmelsbach
billhimmelsbach previously requested changes Oct 22, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
@natalia-fitzgerald natalia-fitzgerald requested review from natalia-fitzgerald and removed request for shindigira October 28, 2024 16:48
natalia-fitzgerald
natalia-fitzgerald previously approved these changes Oct 29, 2024
View reviewed changes
Copy link

@natalia-fitzgerald natalia-fitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meissadia
The responsive menu looks great and aligns closely with the cf.gov responsive menu. I will add the items I noticed (which aren't directly captured by this PR) to a separate ticket.

@meissadia
Copy link
Collaborator

@billhimmelsbach Build + preview issues seem to have resolved themselved 🤷🏾

PR looks good to go.

@meissadia meissadia dismissed billhimmelsbach’s stale review October 29, 2024 18:16

Noted item has been addressed.

billhimmelsbach
billhimmelsbach approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@billhimmelsbach billhimmelsbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go!

@meissadia meissadia merged commit fe8efda into main Oct 29, 2024
4 checks passed
@meissadia meissadia deleted the 918-rwd-menu branch October 29, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billhimmelsbach billhimmelsbach billhimmelsbach approved these changes

@natalia-fitzgerald natalia-fitzgerald natalia-fitzgerald left review comments

@meissadia meissadia Awaiting requested review from meissadia meissadia is a code owner

@tanner-ricks tanner-ricks Awaiting requested review from tanner-ricks tanner-ricks is a code owner

Assignees

@ojbravo ojbravo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Navbar] Mobile Menu Update
5 participants
@ojbravo @billhimmelsbach @shindigira @meissadia @natalia-fitzgerald