Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Point of Contact] Phone extension field #961

Merged
merged 22 commits into from
Sep 30, 2024
Merged

Conversation

shindigira
Copy link
Contributor

@shindigira shindigira commented Sep 23, 2024

Note

Be sure the pull the latest from sbl-filing via yarn update

closes #945

Changes

  • feat(Point of Contact): Added Phone Extension field to Point of Contact Field
  • chore(Point of Contact): Phone Extension breakpoint of 600px
  • feat(Sign and Submit): Added Phone Extension field to Verification field
  • chore(Sign and Submit): Matched order of fields to be the same as Point of Contact
  • feat(e2e): Added Phone Extension field to e2e test
  • style(DisplayField): added work-break: break-all;
  • content(Sign and Submit): added 'Extension'

How to test this PR

First Test

  1. Upload a filing and navigate all the way to Point of Contact
  2. Verify the Phone Extension in both mobile and desktop (901 px and above)
  3. Open the Network tab, submit and verify the request and response jsons contain the phone extension (i.e. phone_ext)

Second Test

  1. Navigate all the way to Sign and Submit
  2. Verify the DisplayField contains the submitted phone extension

Third Test

  1. Run yarn run test:e2e
  2. Run the sign-and-submit test to ensure it passes

Screenshots

PoC (Desktop) PoC (Mobile) Sign and Submit
Screenshot 2024-09-30 at 9 07 06 AM Screenshot 2024-09-30 at 9 07 20 AM Screenshot 2024-09-30 at 2 18 43 PM

@shindigira shindigira changed the title WIP point of contact phone extension [Point of Contact] Phone extension field Sep 24, 2024
@shindigira shindigira marked this pull request as ready for review September 25, 2024 04:47
@billhimmelsbach
Copy link
Contributor

Want to add extension to the existing e2e tests @shindigira?

@shindigira
Copy link
Contributor Author

Want to add extension to the existing e2e tests @shindigira?

Added as part of the test fixture

Copy link
Contributor

@billhimmelsbach billhimmelsbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I'm not seeing that mobile design?
Screenshot 2024-09-27 at 4 38 34 PM

@shindigira
Copy link
Contributor Author

Hmm, I'm not seeing that mobile design? Screenshot 2024-09-27 at 4 38 34 PM

Thanks for that. Reverted back to stacking during mobile.
Screenshot 2024-09-27 at 4 53 35 PM

Copy link
Contributor

@billhimmelsbach billhimmelsbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For optional fields on the point of contact sign and submit page, if they're not included, we don't show them. Could you fix this behavior @shindigira?

Screenshot 2024-09-30 at 7 46 30 AM

@shindigira
Copy link
Contributor Author

For optional fields on the point of contact sign and submit page, if they're not included, we don't show them. Could you fix this behavior @shindigira?

Screenshot 2024-09-30 at 7 46 30 AM

This has been corrected. Thanks for finding it.

@billhimmelsbach
Copy link
Contributor

Great! Let's put this on dev @shindigira

Copy link
Contributor

@billhimmelsbach billhimmelsbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Works great.

@shindigira shindigira merged commit 7368475 into main Sep 30, 2024
4 checks passed
@shindigira shindigira deleted the 945-phone-extension-field branch September 30, 2024 22:46
billhimmelsbach pushed a commit that referenced this pull request Oct 1, 2024
Be sure the pull the latest from
[_sbl-filing_](cfpb/sbl-filing-api#421) via
`yarn update`

closes #945

- feat(Point of Contact): Added Phone Extension field to Point of
Contact Field
- chore(Point of Contact): Phone Extension breakpoint of 600px
- feat(Sign and Submit): Added Phone Extension field to Verification
field
- chore(Sign and Submit): Matched order of fields to be the same as
Point of Contact
- feat(e2e): Added Phone Extension field to e2e test
- style(DisplayField): added `work-break: break-all;`
- content(Sign and Submit): added 'Extension'

1. Upload a filing and navigate all the way to _Point of Contact_
2. Verify the Phone Extension in both mobile and desktop (901 px and
_above_)
3. Open the Network tab, submit and verify the request and response
jsons contain the phone extension (i.e. `phone_ext`)

1. Navigate all the way to _Sign and Submit_
2. Verify the `DisplayField` contains the submitted phone extension

1. Run `yarn run test:e2e`
2. Run the _sign-and-submit_ test to ensure it passes

| PoC (Desktop) | PoC (Mobile) | Sign and Submit |
| -------- | ------- | ------- |
|<img width="533" alt="Screenshot 2024-09-30 at 9 07 06 AM"
src="https://github.com/user-attachments/assets/2210a4d8-e088-4cad-9d78-392aabc0de41">|<img
width="516" alt="Screenshot 2024-09-30 at 9 07 20 AM"
src="https://github.com/user-attachments/assets/cc203268-85bf-4826-8adc-d4740d1a91ea">|<img
width="632" alt="Screenshot 2024-09-30 at 2 18 43 PM"
src="https://github.com/user-attachments/assets/d18a1416-1cbc-494f-a561-d3cd44df22ba">|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] [Point of Contact] Add the Phone Extension field
2 participants