-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Point of Contact] Phone extension field #961
Conversation
Want to add extension to the existing e2e tests @shindigira? |
Added as part of the test fixture |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For optional fields on the point of contact sign and submit page, if they're not included, we don't show them. Could you fix this behavior @shindigira?
This has been corrected. Thanks for finding it. |
Great! Let's put this on dev @shindigira |
…end into 945-phone-extension-field
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Works great.
Be sure the pull the latest from [_sbl-filing_](cfpb/sbl-filing-api#421) via `yarn update` closes #945 - feat(Point of Contact): Added Phone Extension field to Point of Contact Field - chore(Point of Contact): Phone Extension breakpoint of 600px - feat(Sign and Submit): Added Phone Extension field to Verification field - chore(Sign and Submit): Matched order of fields to be the same as Point of Contact - feat(e2e): Added Phone Extension field to e2e test - style(DisplayField): added `work-break: break-all;` - content(Sign and Submit): added 'Extension' 1. Upload a filing and navigate all the way to _Point of Contact_ 2. Verify the Phone Extension in both mobile and desktop (901 px and _above_) 3. Open the Network tab, submit and verify the request and response jsons contain the phone extension (i.e. `phone_ext`) 1. Navigate all the way to _Sign and Submit_ 2. Verify the `DisplayField` contains the submitted phone extension 1. Run `yarn run test:e2e` 2. Run the _sign-and-submit_ test to ensure it passes | PoC (Desktop) | PoC (Mobile) | Sign and Submit | | -------- | ------- | ------- | |<img width="533" alt="Screenshot 2024-09-30 at 9 07 06 AM" src="https://github.com/user-attachments/assets/2210a4d8-e088-4cad-9d78-392aabc0de41">|<img width="516" alt="Screenshot 2024-09-30 at 9 07 20 AM" src="https://github.com/user-attachments/assets/cc203268-85bf-4826-8adc-d4740d1a91ea">|<img width="632" alt="Screenshot 2024-09-30 at 2 18 43 PM" src="https://github.com/user-attachments/assets/d18a1416-1cbc-494f-a561-d3cd44df22ba">|
Note
Be sure the pull the latest from sbl-filing via
yarn update
closes #945
Changes
work-break: break-all;
How to test this PR
First Test
phone_ext
)Second Test
DisplayField
contains the submitted phone extensionThird Test
yarn run test:e2e
Screenshots