Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e2e] Verify users cannot skip Filing steps #989

Merged
merged 11 commits into from
Oct 15, 2024

Conversation

meissadia
Copy link
Collaborator

@meissadia meissadia commented Oct 8, 2024

Closes #980

Verify that, from a given step in the Filing process, a user is prevented from accessing future Filing steps.

Changes

  • Add fixture: navigateToSyntaxErrorsAfterSyntaxErrorsUpload
  • Add fixture: navigateToLogicErrorsAfterLogicErrorsUpload
  • e2e/pages/filing-app/filing-step-routing/_shared.ts: Common logic for validating Filing step redirects
  • e2e/pages/filing-app/filing-step-routing/*: Tests validating that users cannot skip steps

How to test this PR

  1. Run the filing-app => filing-step-routing set of Playwright tests

Screenshots

Screenshot 2024-10-08 at 2 50 04 PM

@meissadia meissadia marked this pull request as ready for review October 8, 2024 22:37
@meissadia meissadia force-pushed the 980-e2e-prevent-filing-step-skips branch from 9cf315a to fbe5390 Compare October 9, 2024 19:57
Copy link
Contributor

@shindigira shindigira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor small change, one optional change and g2g

Copy link
Contributor

@shindigira shindigira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are functioning properly for me.

@meissadia meissadia merged commit eb225ac into main Oct 15, 2024
4 checks passed
@meissadia meissadia deleted the 980-e2e-prevent-filing-step-skips branch October 15, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[e2e] Prevent users from skipping Filing steps
2 participants