generated from cfpb/open-source-project-template
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[e2e] Verify users cannot skip Filing steps #989
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meissadia
requested review from
billhimmelsbach,
shindigira and
ojbravo
as code owners
October 8, 2024 22:37
meissadia
force-pushed
the
980-e2e-prevent-filing-step-skips
branch
from
October 9, 2024 19:57
9cf315a
to
fbe5390
Compare
shindigira
reviewed
Oct 9, 2024
shindigira
reviewed
Oct 9, 2024
shindigira
reviewed
Oct 9, 2024
shindigira
previously requested changes
Oct 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor small change, one optional change and g2g
Co-authored-by: S T <shindigira@gmail.com>
meissadia
force-pushed
the
980-e2e-prevent-filing-step-skips
branch
from
October 10, 2024 16:08
3a6df00
to
53d646b
Compare
shindigira
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are functioning properly for me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #980
Verify that, from a given step in the Filing process, a user is prevented from accessing future Filing steps.
Changes
navigateToSyntaxErrorsAfterSyntaxErrorsUpload
navigateToLogicErrorsAfterLogicErrorsUpload
e2e/pages/filing-app/filing-step-routing/_shared.ts
: Common logic for validating Filing step redirectse2e/pages/filing-app/filing-step-routing/*
: Tests validating that users cannot skip stepsHow to test this PR
filing-app
=>filing-step-routing
set of Playwright testsScreenshots