Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support/wagtail 3 #58

Closed
wants to merge 4 commits into from
Closed

Support/wagtail 3 #58

wants to merge 4 commits into from

Conversation

nickmoreton
Copy link

@nickmoreton nickmoreton commented Jul 19, 2022

This changes the package so it is compatible with Wagtail v3.0

Wagtail 3 upgrade/release notes: https://docs.wagtail.org/en/stable/releases/3.0.html

Additions

Add new module import paths, including for Wagtail versions earlier than 3.0

Removals

Remove compatibility with Wagtail versions earlier than 2.15

Changes

Alter setup.py and tox to accommodate version changes. I have also copied these from the earlier work on wagtail-sharing to better match your current preferred setup here.

Testing

No changes

Screenshots

None

Notes

None

Todos

None

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the development playbook
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Browsers

  • Chrome
  • Firefox
  • Safari
  • Internet Explorer 8, 9, 10, and 11
  • Edge
  • iOS Safari
  • Chrome for Android

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

@nickmoreton nickmoreton marked this pull request as ready for review July 19, 2022 10:25
@rgs258
Copy link

rgs258 commented Oct 18, 2022

Hi @chosak, this change looks pretty good. I wonder if CFPB might be able to run a release for Wagtail 3? if you're too busy, no worries - we can certainly run the branch for now!

thanks

@chosak
Copy link
Member

chosak commented Nov 10, 2022

Thank you @nickmoreton, overtaken by #63.

@chosak chosak closed this Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants