Separate events and alerts for blinker signals. (#105)

* Add separate events for left and right turn signals. * Break out events for left and right blinker signals. * Created separate alerts for right and left blinker signals.
cfranyota · Jan 18, 2019 · 4cddcdd · 4cddcdd
1 parent 0260633
commit 4cddcdd
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 10 deletions.
diff --git a/cereal/car.capnp b/cereal/car.capnp
@@ -73,7 +73,8 @@ struct CarEvent @0x9b1657f34caf3ad3 {
     lowBattery @48;
     invalidGiraffeHonda @49;
     manualSteeringRequired @50;
-    manualSteeringRequiredBlinkersOn @51;
+    manualSteeringRequiredBlinkerOnLeft @51;
+    manualSteeringRequiredBlinkerOnRight @52;
   }
 }
 

diff --git a/selfdrive/car/honda/interface.py b/selfdrive/car/honda/interface.py
@@ -522,8 +522,10 @@ def update(self, c):
 
     if not self.CS.lkMode:
       events.append(create_event('manualSteeringRequired', [ET.WARNING]))
-    elif self.CS.lkMode and (self.CS.left_blinker_on or self.CS.right_blinker_on):
-      events.append(create_event('manualSteeringRequiredBlinkersOn', [ET.WARNING]))
+    elif self.CS.lkMode and self.CS.left_blinker_on:
+      events.append(create_event('manualSteeringRequiredBlinkerOnLeft', [ET.WARNING]))
+    elif self.CS.lkMode and self.CS.right_blinker_on:
+      events.append(create_event('manualSteeringRequiredBlinkerOnRight', [ET.WARNING]))
     elif self.CS.steer_error:
       events.append(create_event('steerUnavailable', [ET.NO_ENTRY, ET.IMMEDIATE_DISABLE, ET.PERMANENT]))
     elif self.CS.steer_warning:

diff --git a/selfdrive/controls/lib/alerts.py b/selfdrive/controls/lib/alerts.py
@@ -107,13 +107,20 @@ def __gt__(self, alert2):
       "Steering is Off - Press LKAS button to turn On",
       AlertStatus.userPrompt, AlertSize.mid,
       Priority.LOW, VisualAlert.none, AudibleAlert.none, .2, .2, .2),
-
-  Alert(
-      "manualSteeringRequiredBlinkersOn",
-      "MANUAL STEERING REQUIRED",
-      "Left or Right Signal is On",
-      AlertStatus.userPrompt, AlertSize.mid,
-      Priority.LOW, VisualAlert.none, AudibleAlert.none, .2, .2, .2),
+
+    Alert(
+        "manualSteeringRequiredBlinkerOnLeft",
+        "MANUAL STEERING REQUIRED",
+        "Left Turn Signal is On",
+        AlertStatus.userPrompt, AlertSize.mid,
+        Priority.LOW, VisualAlert.none, AudibleAlert.none, .2, .2, .2),
+
+    Alert(
+        "manualSteeringRequiredBlinkerOnRight",
+        "MANUAL STEERING REQUIRED",
+        "Right Turn Signal is On",
+        AlertStatus.userPrompt, AlertSize.mid,
+        Priority.LOW, VisualAlert.none, AudibleAlert.none, .2, .2, .2),
 
   Alert(
       "preDriverDistracted",