small fixes for #189 #190
Closed
small fixes for #189 #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannesugb
requested changes
Dec 15, 2023
Comment on lines
+103
to
+109
| Controls: | ||
| * **WASD** | ||
| * **E/Q** for up/down | ||
| * **Shift** to go faster | ||
| * **Esc** to exit | ||
| * **F1** to Toggle input-mode (UI vs. scene navigation) | ||
|
|
There was a problem hiding this comment.
I'd have to ask you to remove these again, because the part about F1 is no longer true in latest development.
| @@ -463,6 +463,7 @@ int main() // <== Starting point == | |||
| avk::application_name("Auto-Vk-Toolkit Example: Ray Query in Ray Tracing Shaders"), | |||
| avk::required_device_extensions() | |||
| // We need several extensions for ray tracing: | |||
| .add_extension(VK_KHR_ACCELERATION_STRUCTURE_EXTENSION_NAME) | |||
There was a problem hiding this comment.
Please unify whitespaces (see line below)
| @@ -451,6 +451,7 @@ int main() // <== Starting point == | |||
| avk::application_name("Auto-Vk-Toolkit Example: Real-Time Ray Tracing - Custom Intersection Example"), | |||
| #if VK_HEADER_VERSION >= 162 | |||
| avk::required_device_extensions() | |||
| .add_extension(VK_KHR_ACCELERATION_STRUCTURE_EXTENSION_NAME) | |||
There was a problem hiding this comment.
Please unify whitespaces (see line below)
| @@ -465,6 +465,7 @@ int main() // <== Starting point == | |||
| avk::application_name("Auto-Vk-Toolkit Example: Real-Time Ray Tracing with Shadows and AO"), | |||
| avk::required_device_extensions() | |||
| // We need several extensions for ray tracing: | |||
| .add_extension(VK_KHR_ACCELERATION_STRUCTURE_EXTENSION_NAME) | |||
There was a problem hiding this comment.
Please unify whitespaces (see line below)
|
no activity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#189