Skip to content

Commit

Permalink
Disable dlfilter by default
Browse files Browse the repository at this point in the history
Per janestreet#246, I think it's busted right now in the face of trace errors.
Lets turn it off by default until we ship a solution.
  • Loading branch information
cgaebel committed Aug 7, 2022
1 parent d51d797 commit 7e3f057
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions core/env_vars.ml
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,10 @@ let debug = Option.is_some (Unix.getenv "MAGIC_TRACE_DEBUG")
features of magic-trace. *)
let experimental = Option.is_some (Unix.getenv "MAGIC_TRACE_EXPERIMENTAL")

(* When tracing the kernel on certain systems, perf only has root access when
(* magic-trace's dlfilter integration is busted right now, see #246. Also:
When tracing the kernel on certain systems, perf only has root access when
being run with a specific set of flags. Since this does not include
[--dlfilter], this environment variable allows the user to forcibly disable
filtering. *)
let no_dlfilter = Option.is_some (Unix.getenv "MAGIC_TRACE_NO_DLFILTER")
let no_dlfilter = Option.is_none (Unix.getenv "MAGIC_TRACE_ENABLE_DLFILTER")

0 comments on commit 7e3f057

Please sign in to comment.