Skip to content
This repository has been archived by the owner on Feb 26, 2023. It is now read-only.

Feature/metrics #17

Merged
merged 20 commits into from
Nov 26, 2021
Merged

Feature/metrics #17

merged 20 commits into from
Nov 26, 2021

Conversation

anvelezec
Copy link
Contributor

This pull request has the implementation of mean absolute error, as well as some unit test cases.

@cgarciae
Copy link
Owner

cgarciae commented Nov 2, 2021

@anvelezec please rebase :)

@cgarciae
Copy link
Owner

cgarciae commented Nov 4, 2021

@anvelezec would be cool if we could do more exhaustive tests using hypothesis like the one in here:

treex/tests/losses/crossentropy_test.py

Line 21 in 3fa7421

class TestCrossentropy:

@cgarciae
Copy link
Owner

@anvelezec can you accept the suggested changes? This PR is good to go.

@cgarciae cgarciae merged commit 928a8b9 into cgarciae:master Nov 26, 2021
@jmarrietar jmarrietar mentioned this pull request Dec 4, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cgarciae cgarciae cgarciae left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anvelezec @cgarciae