Skip to content
This repository has been archived by the owner on Mar 17, 2024. It is now read-only.

Make @codechecks/client peer dep optional #257

Merged
merged 1 commit into from
Nov 25, 2021

Conversation

clemsos
Copy link
Contributor

@clemsos clemsos commented Sep 1, 2021

this should address #229 and prevent yarn/npm from throwing warnings

@PaulRBerg
Copy link

Yes, please! This would be great. I am getting this yarn warning when I install dependencies, and I would rather not install the @codechecks/client package because I don't intend to use it. For what it's worth, I am using Coveralls.

hardhat-gas-reporter@npm:1.0.4 [8a9f5] doesn't provide @codechecks/client (p7b18b), requested by eth-gas-reporter

@cgewecke cgewecke merged commit c8c10b9 into cgewecke:master Nov 25, 2021
@clemsos clemsos deleted the make-codechecks-optional branch November 26, 2021 06:06
"peerDependenciesMeta": {
"@codechecks/client": {
"optional": true
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing comma is throwing a parsing error.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants