Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JOSE] First Release and Archive of the datasets #17

Closed
BenjMy opened this issue Dec 19, 2022 · 7 comments
Closed

[JOSE] First Release and Archive of the datasets #17

BenjMy opened this issue Dec 19, 2022 · 7 comments

Comments

@BenjMy
Copy link

BenjMy commented Dec 19, 2022

xref openjournals/jose-reviews#185

Yet there is no release of the proposed package and archive of the datasets.
I suggest creating one (even if it is a beta) and linking it to a data repository to assign a DOI (GitHub integration with Zenodo is probably the easiest way see here

@AlexanderJuestel
Copy link
Collaborator

Hello @BenjMy,

this relates back to #13 where I was wondering if you would like to see a Pypi and conda release. The Zenode integration is certainly something we can implement.

Cheers
Alex

@AlexanderJuestel
Copy link
Collaborator

The integration with Zenodo was enabled and I have made a first pre-release. The next pre-release or final release then will contain all your requested changes. I also added a cff file for a better citation: https://github.com/cgre-aachen/gemgis_data/blob/main/CITATION.cff

https://zenodo.org/account/settings/github/repository/cgre-aachen/gemgis_data#

image

@AlexanderJuestel
Copy link
Collaborator

@BenjMy,

I tried uploading the package to PyPi, however, the repo is too large (see screenshot).

What we could do now is moving all the data to our owncloud and just download the tutorial data using pooch? What would you think about that?

image

@BenjMy
Copy link
Author

BenjMy commented Jan 11, 2023

Sounds good to consider pooch to fetch the data.
I don't know how much work is required for that. Actually, I've seen that you already have it implemented on gemgis no?
gemgis/download_gemgis_data.py

@AlexanderJuestel
Copy link
Collaborator

Hey,

yes, it is already implemented in GemGIS and I have the data already uploaded to our server, so not that much more work is required here, actually.

But since you said, that we do not need a PyPi release of gemgis_data, this becomes obsolete and we can keep the data in the repo where all users can see it right away?

@BenjMy
Copy link
Author

BenjMy commented Jan 11, 2023

Ok agreed. Please feel free to close the issue.

@AlexanderJuestel
Copy link
Collaborator

Nevertheless, I will have to create an archive for the final publication of the paper with the reworked repo and everything.

Closing the issue as instructed by reviewer :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants