Directly use the checked out action #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking out a copy of this action with a fixed revision is surprising and makes it difficult to pin actions properly since the action itself will by default always checkout `v1` again. One would have to duplicate the revision / version on the use site to be safe.
avdv
force-pushed
the
cb/no-duplicate-checkout
branch
from
8d07b7d to
1395fc0
Compare
cgrindel
approved these changes
Dec 10, 2024
|
I just created release 1.4.0 with this fix. Thank you! |
Thank you, Chuck! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note, this is based on #68Checking out a copy of this action on every run with a fixed revision (by default) is surprising and makes it difficult to pin actions properly since the action itself will by default always checkout
v1again -- one would have to duplicate the revision / version on the use site to be safe.I tested using the action from this PR here: tweag/gazelle_cabal#129 (action run: https://github.com/tweag/gazelle_cabal/actions/runs/12257035146/job/34195222238?pr=129)