Skip to content

Commit

Permalink
05core: skip sysroot.mount for remote kdump
Browse files Browse the repository at this point in the history
If kdump is setup to upload logs to a remote host, the
XFS module may not be loaded, which cause sysroot.mount to fail.

If the target for logs is SSH, kdump will boot with a `kdump_remote_ip`
karg. Skip generating sysroot.mount in that case so kdump can boot
without having to load XFS.

This is a temporary fix until we migrate older systems to have a root
karg: coreos/fedora-coreos-tracker#1675

See https://issues.redhat.com/browse/OCPBUGS-27935
  • Loading branch information
jbtrystram authored and jlebon committed Feb 17, 2024
1 parent 32ee5d5 commit 1d757f4
Showing 1 changed file with 5 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,11 @@ mkdir -p ${UNIT_DIR}
# We want to generate sysroot.mount on ostree systems, but we don't want
# to run if there's already a root= karg, where the systemd-fstab-generator
# should win.
if test -n "$(cmdline_arg ostree)" && test -z "$(cmdline_arg root)"; then
# We also don't want to generate sysroot.mount if we are booting a kdump kernel
# that aims to upload logs to a remote target, as the XFS kernel module won't be loaded
# https://issues.redhat.com/browse/OCPBUGS-27935
# FIXME: this kdump case should be removed when we are done with https://github.com/coreos/fedora-coreos-tracker/issues/1675
if test -n "$(cmdline_arg ostree)" && test -z "$(cmdline_arg root)" && test -z "$(cmdline_arg kdump_remote_ip)"; then
cat >${UNIT_DIR}/sysroot.mount << 'EOF'
[Unit]
Before=initrd-root-fs.target
Expand Down

0 comments on commit 1d757f4

Please sign in to comment.