Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need better error message when submodules are missing. #16

Closed
dustymabe opened this issue Mar 29, 2016 · 0 comments
Closed

Need better error message when submodules are missing. #16

dustymabe opened this issue Mar 29, 2016 · 0 comments

Comments

@dustymabe
Copy link

so just tried to use git-evtag to verify the latest tag from rpm-ostree and I'm seeing an issue:

$ rpm -q git-evtag
git-evtag-2016.1-1.fc22.x86_64
$ git checkout v2016.1
...
$ git-evtag verify v2016.1
gpg: Signature made Mon 28 Mar 2016 11:13:48 AM EDT using RSA key ID 21C13F0B
gpg: Good signature from "Colin Walters <walters@redhat.com>"
gpg:                 aka "Colin Walters <walters@verbum.org>"
gpg: WARNING: This key is not certified with a trusted signature!
gpg:          There is no indication that the signature belongs to the owner.
Primary key fingerprint: 1CEC 7A9D F7DA 85AB EF84  3DC0 A866 D7CC AE08 7291
     Subkey fingerprint: AB92 8A9C F8DD 0629 09C3  7BBD DC45 FD59 21C1 3F0B
error: Failed to resolve path '/home/dustymabe/Desktop/development/rpm-ostree/libglnx/.git': No such file or directory

Colin pointed out this is an issue because I haven't ran git submodule update --init. We need a better error message for this.

cgwalters added a commit that referenced this issue Mar 29, 2016
First, we need to cleanly break iteration if we caught an error.  Fix
our return code checks to use `!= 0`, and break the iterator as early
as possible if we flagged an error.

Second, if we fail to open a submodule, give the user a hint.

Closes #16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant