spec: make proper spec for review #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Igor Gnatenko <ignatenko@redhat.com>
| @@ -1,17 +1,15 @@ | |||
| %global commit0 74fb3c0814152de193bac65a53b86a08a25ecb79 | |||
| %global gittag0 v2016.1 | |||
| %global shortcommit0 %(c=%{commit0}; echo ${c:0:7}) | |||
There was a problem hiding this comment.
These are pretty standard bits now; see https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL
There was a problem hiding this comment.
in case you use git snapshot - yes, but not when you use released version. also that hardcoded stuff. if you will bump Version tag, you will still download same sources.
|
It's not clear to me what makes this a "proper spec" that it wasn't before, but sure. |
|
💡 This pull request was already approved, no need to approve it again. |
cgwalters-bot
pushed a commit
that referenced
this pull request
Jul 12, 2016
Signed-off-by: Igor Gnatenko <ignatenko@redhat.com> Closes: #22 Approved by: cgwalters
|
💥 Test timed out |
|
@cgwalters-bot retry |
1 similar comment
|
@cgwalters-bot retry |
|
Unfortunately homu-travis integration is busted at the moment. Merged by hand for now, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.