Fix nested submodules #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While top-level submodules (e.g. $GIT_DIR/mysubmodule) were working fine, those in subdirectories (for example, $GIT_DIR/subprojects/mysubmodule) were not, since the middle part of the path (‘subprojects’) was being dropped during the checksum recursion. Fixing this is especially important for any project using Meson-style subprojects, which are conventionally all grouped in the ‘subprojects’ directory. Signed-off-by: Philip Withnall <withnall@endlessm.com>
As in the previous commit. Signed-off-by: Philip Withnall <withnall@endlessm.com>
Signed-off-by: Philip Withnall <withnall@endlessm.com>
pwithnall
force-pushed
the
fix-nested-submodules
branch
from
5565995
to
d96af5d
Compare
|
Trivially rebased and added one tiny fix to the TAP line which lists the number of tests. I haven’t re-tested it; that can be done if anyone ever takes a look at this for review. |
|
Any chance of getting this reviewed and landed? I’ve been using it for over a year without problems now, and aiui it’s not possible to release GLib without it (due to use of submodules within Meson’s |
|
/cc @cgwalters |
|
Would be quite nice to have this merged and released :) |
|
Sorry, I completely missed notifications for this! Looks good to me! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While top-level submodules (e.g. $GIT_DIR/mysubmodule) were working
fine, those in subdirectories (for example,
$GIT_DIR/subprojects/mysubmodule) were not, since the middle part of the
path (‘subprojects’) was being dropped during the checksum recursion.
Fixing this is especially important for any project using Meson-style
subprojects, which are conventionally all grouped in the ‘subprojects’
directory.
Signed-off-by: Philip Withnall withnall@endlessm.com