Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Add a Meson build system #43

Merged
merged 4 commits into from
Nov 13, 2022
Merged

build: Add a Meson build system #43

merged 4 commits into from
Nov 13, 2022

Conversation

smcv
Copy link
Collaborator

@smcv smcv commented Nov 12, 2022

  • man: Include source code for the man page in dist tarballs

  • rust: Fix build of git-rustevtag

    It's now built as git-evtag by the Cargo build system, so we need to
    rename it as part of copying it.

  • tests: Be more strict about producing TAP output

    Autotools' TAP parser ignores unknown content on stdout, but Meson is
    much more strict and considers unknown content to be an error. Redirect
    commands' stdout to stderr if they can produce arbitrary unstructured
    diagnostics on stdout.

  • build: Add a Meson build system

Signed-off-by: Simon McVittie <smcv@debian.org>
It's now built as git-evtag by the Cargo build system, so we need to
rename it as part of copying it.

Signed-off-by: Simon McVittie <smcv@debian.org>
Autotools' TAP parser ignores unknown content on stdout, but Meson is
much more strict and considers unknown content to be an error. Redirect
commands' stdout to stderr if they can produce arbitrary unstructured
diagnostics on stdout.

Signed-off-by: Simon McVittie <smcv@debian.org>
Signed-off-by: Simon McVittie <smcv@debian.org>
@smcv smcv marked this pull request as ready for review November 12, 2022 16:33
@smcv
Copy link
Collaborator Author

smcv commented Nov 12, 2022

@cgwalters, are you interested in adding a Meson build system, and potentially dropping the Autotools build at some point?

(If not, I can move the first three commits into a separate PR.)

Copy link
Owner

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Dropping autotools seems fine to me. Thanks so much for all your work on this!

@cgwalters cgwalters merged commit f6e1453 into cgwalters:main Nov 13, 2022
@eli-schwartz
Copy link

  • tests: Be more strict about producing TAP output
    Autotools' TAP parser ignores unknown content on stdout, but Meson is
    much more strict and considers unknown content to be an error. Redirect
    commands' stdout to stderr if they can produce arbitrary unstructured
    diagnostics on stdout.

Note: The TAP specification says that unknown lines are never parser errors, in order to allow for forward compatibility with new versions of TAP, but they may be harness errors, and some harnesses error, some ignore it, and some non-fatally warn about it.

The intention of unknown lines is, regardless, intended specifically for not-yet-implemented TAP keywords, and arbitrary content emitted by programs run within the test should be prefixed with # as the first character on the line, in order to be parsed as TAP diagnostics (that is, comments, which cannot affect the tests themselves but may of course be displayed by the harness for informational purposes).

@smcv smcv mentioned this pull request Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants