Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to PHP 8 #3

Merged
merged 7 commits into from
Oct 19, 2021
Merged

Bump to PHP 8 #3

merged 7 commits into from
Oct 19, 2021

Conversation

ch2877
Copy link
Owner

@ch2877 ch2877 commented Oct 18, 2021 •
edited
Loading

Bump to PHP8

@ch2877
Copy link
Owner Author

ch2877 commented Oct 18, 2021

@toooni
Bumping the PHPUnit version 8 or 9 will mean that we need to bump the PHP Version to 7.2.

@toooni
Copy link
Collaborator

toooni commented Oct 19, 2021

@ch2877 Yes. PHP 7.2 had it's EOL almost a year ago. And since this update does not offer new features, there is no need to keep it IMO. Don't you think?

@ch2877
Copy link
Owner Author

ch2877 commented Oct 19, 2021

@sprain @eric-reichenbach
Do you aggree with these changes?
I will release it as v1.1.0

sprain
sprain reviewed Oct 19, 2021
View reviewed changes
CHANGELOG.md Outdated
## 1.1.0 (2021-xx-yy)

* Renamed Mixed to MixedMoney (reserved word as of PHP 7).
* Dropped support for PHP 5.6.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropped support for PHP 5.6.
belongs to v1.0

1.1 would need a notice that support for PHP 7.0 to 7.1 was dropped.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed Mixed to MixedMoney (reserved word as of PHP 7).

Oh … and would this make it a v2.0 as it is a bc break?

@eric-reichenbach
Copy link
Collaborator

Fine by me, once it's merge into master we would just need to add to the change log:

"Added support for QR Bills (BankCreditTransferWithCreditorReference, BankCreditTransferWithQRR)"

As well as explicitly stating on the readme.md the compatible PHP versions

@ch2877 ch2877 merged commit c85bb22 into master Oct 19, 2021
@sprain sprain deleted the php8 branch October 19, 2021 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sprain sprain sprain left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ch2877 @toooni @eric-reichenbach @sprain @will2877