Remove GPIOE remappings for USART4 & TIM1 on some ch32v20x chips #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following chips don't have GPIOE, but the default USART4/TIM1 peripheral defines remappings on GPIOE that are available on other chips, which prevents building for these:
I've added the
V2x_USART4peripheral (even though it's actually a UART, as are 6-8) which is basically a copy ofFV2x_V3x_USART4that doesn't include the PE remappings. Although it's worth mentioning that I set the global interrupt signal toUART4, because it wouldn't build withUSART4.Finally, I updated the references to the existing version of
ADV_TIM1which doesn't have PE remappings.