Implement I2C for embedded-hal-async #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. I'll add the missing |
|
It seems the current async I2C implementation is buggy. I'll review this when impl is fixed. |
|
Yes, I was having some issues with it as well. It seems that some I2C interrupts aren't triggering, thus keeping the respective polling tasks from awaking. On the other hand, the DMA interrupts work. The transactions are successful if they are fast enough, where the polling exits immediately after checking the status register. |
|
I have tried the same this week-end with a SH1107 OLED display and the communication was not working but I did try to debug it yet. |
|
The DMA seems not starting. I'll compare the reg diffs vs the official EVT code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows using HAL with async device drivers.