bugfix(broken atomic): atomic removal #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checks are broken until new qingke is published |
Codetector1374
force-pushed
the
atomic-removal
branch
from
96f47ec
to
144a644
Compare
Codetector1374
commented
Nov 3, 2024
| "data-layout": "e-m:e-p:32:32-i64:64-n32-S128", | ||
| "eh-frame-header": false, | ||
| "emit-debug-gdb-scripts": false, | ||
| "features": "+m,+f,+c,+forced-atomics", |
There was a problem hiding this comment.
+forced-atomics is actually in every single none target. Which means core::atomic::* actually exists.
Codetector1374
commented
Nov 3, 2024
| @@ -0,0 +1,19 @@ | |||
| { | |||
| "arch": "riscv32", | |||
| "atomic-cas": false, | |||
There was a problem hiding this comment.
This is what disables compare_and_swap
Codetector1374
force-pushed
the
atomic-removal
branch
from
9ee0488
to
a2aa82e
Compare
This change remvoes all use of atomic (CAS) from ch32-hal As discovered in ch32-rs#59, the QingKeV4 atomic implementation is likely broken. As a result we added a compiler check to make sure the atomic exetnsion is disabled in ch32-rs/qingke#8. This change updates the dependency to use the new qingke as well as remove any reference to `core::atomic` in ch32-hal.
This is a follow-up change to the `bugfix(broken atomics)` where we removed all use of atomics. This update the qingke version and examples' target setting to not include the atomic extension
Codetector1374
force-pushed
the
atomic-removal
branch
from
a2aa82e
to
83c9f4e
Compare
|
If you want a quick / easy review experience, only look at the |
Codetector1374
changed the title
Codetector1374
commented
Nov 3, 2024
| @@ -130,20 +127,21 @@ impl Driver for SystickDriver { | |||
| let period = self.period.load(Ordering::Relaxed) as u64; | |||
| rb.cnt().read() / period | |||
| } | |||
|
|
|||
| unsafe fn allocate_alarm(&self) -> Option<AlarmHandle> { | |||
There was a problem hiding this comment.
Please take an extra look make sure this is equivalent
andelf
approved these changes
Nov 4, 2024
|
This is another BREAKING CHANGE. CC @romainreignier |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discovered in #59, the QingKeV4 atomic implementation is likely broken. As a result we added a compiler check to make sure the atomic exetnsion is disabled in ch32-rs/qingke#8. This change updates the dependency to use the new qingke as well as remove any reference to
core::atomicin ch32-hal.