Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve GitHub Actions behavior for external PRs #19

Merged
merged 11 commits into from
Feb 11, 2023
Merged

Improve GitHub Actions behavior for external PRs #19

merged 11 commits into from
Feb 11, 2023

Conversation

chabala
Copy link
Owner

@chabala chabala commented Feb 10, 2023

Lack of secret sharing with untrusted forks breaks various integrations

@chabala chabala self-assigned this Feb 10, 2023
@coveralls
Copy link

coveralls commented Feb 11, 2023 •
edited
Loading

Coverage Status

Coverage: 67.223%. Remained the same when pulling 2c7c484 on gh-actions-pr-reports into aa8cd90 on master.

@chabala
add preconditional secret check job for sonar
b41d248
@chabala
missed changing a flag name
2c7c484 
* but also validated it skips the step when the flag is missing
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@chabala chabala merged commit 602cc81 into master Feb 11, 2023
@chabala chabala deleted the gh-actions-pr-reports branch February 11, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@chabala chabala

Labels
continuous integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chabala @coveralls