Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to spandrel v0.2.1 #2487

Merged
merged 1 commit into from
Jan 21, 2024

Conversation

RunDevelopment
Copy link
Member

Fixes #2461.

This updates spandrel to v0.2.1 and changes our code to take advantage of the new API and guarantees. E.g. since spandrel now handles size requirements, I was able to remove our padding code.

@joeyballentine
Copy link
Member

When we update spandrel, we should also always update the link to the supported models section in the readme. I linked to the specific version we use so that it's always correct for whatever chaiNNer currently supports.

@RunDevelopment
Copy link
Member Author

Can't we reasonably expect that chainner will always be close to up to date? I don't think it's a huge problem when the spandrel README lists a few archs that chainner will only support in the next release.

@joeyballentine
Copy link
Member

That's a good point. In that case, can you update it to just point to the normal readme?

Copy link
Member

@joeyballentine joeyballentine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually ill just do it in a separate pr

@joeyballentine joeyballentine merged commit d2385c2 into chaiNNer-org:main Jan 21, 2024
14 checks passed
@RunDevelopment RunDevelopment deleted the spandrel-0.2.1 branch January 21, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pytorch Upscale Image node tiling issue
2 participants