Skip to content

Commit

Permalink
Allow messages to be passed through for "should.become"
Browse files Browse the repository at this point in the history
  • Loading branch information
klamping authored and domenic committed Dec 20, 2015
1 parent d5aefa5 commit f1b7db7
Show file tree
Hide file tree
Showing 2 changed files with 32 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lib/chai-as-promised.js
Original file line number Diff line number Diff line change
Expand Up @@ -233,8 +233,8 @@
doNotify(getBasePromise(this), done);
});

method("become", function (value) {
return this.eventually.deep.equal(value);
method("become", function (value, message) {
return this.eventually.deep.equal(value, message);
});

////////
Expand Down
30 changes: 30 additions & 0 deletions test/custom-messages.coffee
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
"use strict"

describe "Custom messages", =>
promise = null
message = "He told me enough! He told me you killed him!"

beforeEach =>
promise = fulfilledPromise(42)
return undefined

describe "should pass through for .become(value, message) for 42", =>
shouldPass => promise.should.become(42, message)
describe "should pass through for .become(value, message) for 52", =>
shouldFail
op: => promise.should.become(52, message)
message: message

describe "should pass through for .not.become(42, message)", =>
shouldFail
op: => promise.should.not.become(42, message)
message: message
describe "should pass through for .not.become(52, message)", =>
shouldPass => promise.should.not.become(52, message)

describe "should pass through for .eventually.equal(42)", (done) =>
shouldPass => promise.should.eventually.equal(42, message)
describe "should pass through for .not.eventually.equal(42)", (done) =>
shouldFail
op: => promise.should.not.eventually.equal(42, message)
message: message

0 comments on commit f1b7db7

Please sign in to comment.