Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow messages to be passed through for "should.become" #132

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/chai-as-promised.js
Original file line number Diff line number Diff line change
Expand Up @@ -233,8 +233,8 @@
doNotify(getBasePromise(this), done);
});

method("become", function (value) {
return this.eventually.deep.equal(value);
method("become", function (value, message) {
return this.eventually.deep.equal(value, message);
});

////////
Expand Down
21 changes: 21 additions & 0 deletions test/should-eventually.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -145,3 +145,24 @@ describe "Fulfillment value assertions:", =>

describe ".eventually.have.property('foo').that.equals('bar')", =>
shouldPass => promise.should.eventually.have.property('foo').that.equals('bar')

describe "Become messages", =>
message = "He told me enough! He told me you killed him!"

beforeEach =>
promise = fulfilledPromise(42)
return undefined

describe "should pass through for .become(value, message) for 42", =>
shouldPass => promise.should.become(42, message)
describe "should pass through for .become(value, message) for 52", =>
shouldFail
op: => promise.should.become(52, message)
message: message

describe "should pass through for .not.become(42, message)", =>
shouldFail
op: => promise.should.not.become(42, message)
message: message
describe "should pass through for .not.become(52, message)", =>
shouldPass => promise.should.not.become(52, message)