[WIP] feat: update .rejectedWith with new .checkError
#235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 26, 2017
BREAKING CHANGE: Update failed assertion messages for `.rejectedWith` for simplicity, consistency, and correctness. Update `.rejectedWith` to only perform criteria matching on `Error` instances.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Update failed assertion messages for
.rejectedWithfor simplicity, consistency, and correctness. Update
.rejectedWithto only perform criteria matching on
Errorinstances.This PR is a WIP. This PR is demonstrating breaking changes in
chaiandcheck-errorthat aren't released yet (and may not be released if maintainers don't like it). If these changes are released, it'll be done with a major version bump. The purpose of these changes is to drastically simplify the error-checking logic (which in turn simplifiesrejectedWith). It also makes failed assertion messages related to errors more consistent across Chai.Related: chaijs/chai#1021 and chaijs/check-error#18