4.0.0 #202
4.0.0 #202
Conversation
|
This seems to undo a lot of recent changes to README.md |
|
Yes I'll fold them back in. Thanks |
|
😃 |
README.md
Outdated
| }) | ||
| .send({'_method': 'put'}) | ||
| .send({'password': '123'}) | ||
| .send({'confirmPassword', '123'}) |
There was a problem hiding this comment.
Why / when did this change?
|
Sorry this took so long. @meeber care for another review? |
|
What's the 'is-ip' dependency version change for? Assuming that's intended,
then LGTM; merge away!
|
|
@keithamus Will you push this release to npm, too? |
|
Yup! Just need someone to approve this. /cc @meeber @lucasfcosta |
|
@keithamus What's the story behind the |
|
@meeber gimme 5 mins and I'll fix it. Getting build errors. |
|
@meeber done I think. Needed to upgrade |
|
@keithamus @meeber Really straight forward 👍 nice. I appreciate it, that the new version is pushed soon, because installing the package from github has a massive performance disadvantage in our CI build. |
|
Agreed @janis91! The maintainer group has been really busy with external things - e.g. moving country, starting new jobs, and so the amount we've been able to contribute has diminished a lot. We never wanted to get into this position, but it happens. We'll be better with this stuff in the future I'm sure. |
|
@keithamus That's life. ;-) Don't worry. |
|
🎉 |
This is the chore commit to release 4.0.0
Fixes #151 #192