Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #254, add extended request method explanations to the README #256

Merged
merged 1 commit into from
Aug 20, 2019

Conversation

theodorewahle
Copy link
Contributor

No description provided.

@theodorewahle theodorewahle changed the title Add extended request method explanations to the README Fix for issue #254, add extended request method explanations to the README Aug 19, 2019
Copy link
Member

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! This looks much better, thanks @theodorewahle

@austince happy to merge this?

@austince
Copy link
Contributor

This looks great! @theodorewahle, could you just edit your commit message to something like docs: add extended request method explanations and then force push up?

git commit --amend # change the message
git push --force # assuming your branch is set as upstream

@keithamus
Copy link
Member

@austince just FYI we can use "squash and merge" to alter commits in these situations, rather than burden contributors with our commit style.

@austince
Copy link
Contributor

@keithamus, I'm game for that - should we remove the validate-commit-msg status check then?

@keithamus
Copy link
Member

@austince the validate-commit-msg check is not a required check, and so you're able to merge without it passing. I've kept it specifically not-required to allow for that scenario.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants