Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: correctly template github event in if condition for release #283

Merged
merged 2 commits into from
Feb 24, 2021

Conversation

austince
Copy link
Contributor

@austince
Copy link
Contributor Author

@keithamus could you also double check that the NPM_TOKEN secret has been set and is valid?

@austince austince changed the title ci: correctly template github event in if condition for release ci: correctly template github event in if condition for release Feb 24, 2021
@keithamus
Copy link
Member

keithamus commented Feb 24, 2021

Updated the token. Added a comment so we know which token it is from the npm admin list... I wish tokens could have names! (Ref npm/roadmap#21)

@austince
Copy link
Contributor Author

Nice, thanks!

@austince austince merged commit c34b299 into master Feb 24, 2021
@austince austince deleted the ci/correct-publish-if-clause branch February 24, 2021 18:23
@austince
Copy link
Contributor Author

ugh, should be better at ci by now. It's event_name, not event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants