-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: install node deps before release #285
Conversation
@keithamus looks like the github token doesn't have enough credentials to push the release. The minimum it needs is |
That's weird. It should have the GITHUB_TOKEN generated from actions which has repo scope I believe. |
Maybe it can't push to the |
I've got no way currently to check out the branch protections, but that's the only thing I can think to check. |
Yeah, seems to be that, since we persist build artifacts: https://github.com/semantic-release/semantic-release/blob/master/docs/recipes/github-actions.md#pushing-packagejson-changes-to-a-master-branch Not sure if you'd like to add a personal access token, as it seems to be a limitation of GH Actions that you can't scope secrets to branches, but we might be able to avoid overriding |
Aaaaand anotha one. Could do caching, but would just like this to work first. Guess this is what happens when we update the CI and release system and don't use it for two years, hah.
Ran the build locally after a clean
npm ci
install and it succeeded.https://github.com/chaijs/chai-http/runs/1972788417