Update all the things #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: This update features some breaking changes from superagent, for more, read https://github.com/visionmedia/superagent/blob/master/History.md#200
BREAKING CHANGE: Drop support for old versions of Node (<4.0). Only Node LTS and stable are supported
|
@keithamus Are you trying to compete with @lucasfcosta's check error module for most issues/PRs closed by a single commit? I'm afraid his PR still has the edge!! LGTM |
|
Curses I really wanted to win! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hate 5 minutes to update all of the outdated packages in this repo. It means we have a few breaking changes here: namely no more support for Node <4, and also any breaking changes qs or superagent have.
Luckily it means we get to delete some of our code, as superagent now supports promises directly 😄
@meeber happy to take a look?
FYI this closes #96 #94 #89 #88 #87 #84 #82 #74 #54