Support spy.on with nullish prototype (#118)

Fixes #117. Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>
chaijs · Apr 6, 2023 · 419cddd · 419cddd
1 parent bbdb02e
commit 419cddd
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/chai-spies.js b/chai-spies.js
@@ -87,7 +87,7 @@
         object: object
         , methodName: methodName
         , originalMethod: object[methodName]
-        , isOwnMethod: object.hasOwnProperty(methodName)
+        , isOwnMethod: Object.hasOwnProperty.call(object, methodName)
       };
       object[methodName] = method;
 

diff --git a/lib/spy.js b/lib/spy.js
@@ -81,7 +81,7 @@ module.exports = function (chai, _) {
       object: object
       , methodName: methodName
       , originalMethod: object[methodName]
-      , isOwnMethod: object.hasOwnProperty(methodName)
+      , isOwnMethod: Object.hasOwnProperty.call(object, methodName)
     };
     object[methodName] = method;
 

diff --git a/test/spies.js b/test/spies.js
@@ -609,6 +609,16 @@ describe('Chai Spies', function () {
       object.push().should.equal(5);
       object.pop().should.equal(5);
     })
+
+    it('should work with a nullish prototype', function() {
+      var nullish = Object.create(null);
+      nullish.method = function() {
+        return 1;
+      };
+      chai.spy.on(nullish, 'method');
+      nullish.method().should.equal(1);
+    });
+
   });
 
   describe('spy interface', function () {