-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.0.0 #92
Release 1.0.0 #92
Conversation
stalniy
commented
Jan 10, 2018
•
edited
Loading
edited
- documentation
- package.json
3d4f8f9
to
7677de9
Compare
@stalniy as part of this I think we should also drop Node < 4 from the package.json, and no longer support it. Thoughts? |
@keithamus this was done in #91 |
Yup 😆 just saw that and merged. |
If you rebase this against master, the tests will pass and I will merge 👍 |
deprecates chai.spy.returns
7677de9
to
35afb53
Compare
Done! lets merge this :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@keithamus what do we need to do next to publish 1.0.0 on npm? |
@stalniy could you please add some release notes to https://github.com/chaijs/chai-spies/releases/edit/untagged-c4a7ec2f780e17401aef and then hit |
Cool! @keithamus what do you think about merging #93 in 1.0.0 as well? |
Ideally the format should be:
|
Sorry @keithamus , missed your last message. I will change the format. Do you use some tool to generate release notes? |
Also |
@keithamus updated release notes according to recommended format, also added |
I've gone ahead and manually published chai-spies@1.0.0 - it looks like it didnt publish on CI, I'll get around to fixing that later. |