Should it be possible to overwrite a chainable method?

[hazeledmands]

I was trying to add some custom behavior to the length assertion, when I noticed that overwriteMethod doesn't seem work on chainable methods.

Is this by design? Am I missing something fundamental here? Or should there be code in the chai plugin API to let you do something like this:

Assertion.overwriteChainableMethod('length', function(_super, _superChain) {
  if( /* something */ ) {
    return {
      method: function() { /* custom assertion */ },
      chainingBehavior: function() { /* custom chaining behavior */ }
    };
  } else {
    return {
      method: _super,
      chainingBehavior: _superChain
    }
  }
});

Feel free to tell me to write a pull request, just wondering if it's worth my time. Anyway, thanks very much for this library; it's pretty awesome. :)

[logicalparadox]

This is currently not implemented but I think it would be a good idea. Can it look like this:

Assertion.overwriteChainableMethod('length', {
  method: function(_super) {
    return function() {};
  },
  chain: function(_super) {
    return function() {};
  }
});

Might be difficult to separate the chain _super from the method _super with the current way things are done. Open to ideas or PRs...

[hazeledmands]

Hoo boy. I'm beginning to see why this is difficult. This pull request is going to involve some pretty terrifying code, but at least it'll be a jumping-off point for discussion, I hope.

[logicalparadox]

Looking forward to it!