-
-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use chaijs/loupe for inspection #1401
Conversation
I think we'd like https://github.com/chaijs/loupe to display |
I think this one is a good change, please comment if you disagree |
In both of these instances the changes are welcome I think. |
Alright, thanks for the confirmation. For the next ones, I suggest you just add an emoji on the github comment to say that you're OK with the change or add a new comment if you're not. |
Using ISO format for printing dates:
|
Unquoted complex key in objects:
|
We'll need to fix chaijs/loupe#44 as well |
A bit more complex: when using prototype properties, Object.create({tea: 'chai'}) We use to show it as regular properties:
We now exclude them which makes it less readable:
What do you think? |
|
Typed array:
|
I think this is a regression. Ideally loupe would give us inspections which are syntactically valid and can be pasted into a REPL with minimal editing. I think loupe should detect if it needs quotes and add them. |
This looks like a regression. I'd expect |
This is intentional. It is useful to know what typed array class is being inspected. We should update chai here. |
Another one: it('inspect with custom stylize-calling inspect()s', function () {
chai.use(function (_chai, _) {
var obj = {
outer: {
inspect: function (depth, options) {
return options.stylize('Object content', 'string');
}
}
};
expect(_.inspect(obj)).to.equal('{ outer: Object content }');
});
});
|
What does nodejs do here? To me the loupe example seems correct but I’d be interested in Nodes output as it has the same API |
For reference this is Node's API. So the test is correct and I should fix the code. |
To make progress on this, I would now need some reviews on loupe pull requests. @keithamus can you take a look please? https://github.com/chaijs/loupe/pulls |
All fixes on loupe and been merged and published to npm. This should be able to progress now. |
@pcorpet I've also invited you to the chai org as a maintainer for loupe! |
Thanks for the review, this PR should now be good for review as the tests pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM but perhaps a second set of eyes would be good. @flaambe as you worked on this before, do you think this looks good?
}, "expected { tea: \'chai\' } to deeply equal { tea: \'black\' }"); | ||
}, "expected {} to deeply equal {}"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like we're losing data here. Perhaps this should be a feature of loupe that if the object has no own-properties then it can inspect the prototype to make it more useful for instances like this?
message: 'expected [ Array(4) ] to equal [ Array(4) ]' | ||
message: "expected [ 'string1', 'string2', …(2) ] to equal [ 'string5', 'string6', …(2) ]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is so much nicer IMO 👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I was thinking we are going to replace lib/chai/utils/inspect.js
completely?
I agree that's definitely the ultimate goal here. Merging this PR gets us a lot closer to that though so I'm happy to ship this. |
Fix #1228
Note that for now this is just a quick attempt to explore which diffs are OK in the error messages and which ones we'd like to fix in
loupe
before merging.