-
-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish npm packages with provenance #1615
Conversation
- run: npm ci | ||
- run: npm publish | ||
- run: npm run build --if-present | ||
- run: npm version ${TAG_NAME} --git-tag-version=false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean we can create releases without having to push a version bump to main?
Will we lose the tags and version in our package file by doing this? Sounds nice being able to release without the extra push but also I like having tags and the right version in the JSON 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean we can create releases without having to push a version bump to main?
Yes.
Will we lose the tags and version in our package file by doing this? Sounds nice being able to release without the extra push but also I like having tags and the right version in the JSON 😅
Also yes. Typically I set package.json version to 0.0.0-development
so it's clear that the version is generated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries I think that makes sense. @koddsson can you update the package version so that is clear?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
This will allow us to have a cool badge on npm.
Example:
![image](https://private-user-images.githubusercontent.com/318208/329215519-6857f1d6-26f6-4172-86b4-161f8a452c3e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ1MDgzOTEsIm5iZiI6MTcyNDUwODA5MSwicGF0aCI6Ii8zMTgyMDgvMzI5MjE1NTE5LTY4NTdmMWQ2LTI2ZjYtNDE3Mi04NmI0LTE2MWY4YTQ1MmMzZS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwODI0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDgyNFQxNDAxMzFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1kZTZlN2E0M2NiZjNlMDJkNjJiMTE5ZjRkNjliZWJiZGJhZGI3MmQ3YjBiNWIzYWYxNDliZTE0MjJmMGI5NTc4JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.p13wXY5NCzpMEscUVasXVP5v-tNQgZ-wdsYVI5w1Q4M)