Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent playwright installation #72

Closed
unicornware opened this issue Nov 3, 2023 · 2 comments · Fixed by #73
Closed

prevent playwright installation #72

unicornware opened this issue Nov 3, 2023 · 2 comments · Fixed by #73

Comments

@unicornware
Copy link

Current behavior

The postinstall script installs playwright using npx.

When installing loupe during a GitHub Actions workflow, this seems to intermittently cause installation errors. I've re-run several workflows, several times, to workaround this.

Screenshot 2023-11-03 at 2 21 42 AM

Expected behavior

Playwright should be not be installed unless defined in my package dependencies.

Possible solutions

  • add playwright to devDependencies
  • refactor postinstall script

Environment

  Binaries:
    Node: 20.8.0 - ~/.nvm/versions/node/v20.8.0/bin/node
    Yarn: 4.0.0 - ~/.yarn/bin/yarn
    npm: 10.1.0 - ~/.nvm/versions/node/v20.8.0/bin/npm
  npmPackages:
    chai: 5.0.0-alpha.2 => 5.0.0-alpha.2
    loupe: 3.0.0 => 3.0.0 
unicornware added a commit to flex-development/gh-commit that referenced this issue Nov 3, 2023
- chaijs/loupe#72

Signed-off-by: Lexus Drumgold <unicornware@flexdevelopment.llc>
@keithamus
Copy link
Member

keithamus commented Nov 3, 2023

Oh yeah that should be pretest not postinstall. I'll fix this.

@unicornware
Copy link
Author

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants