Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for different types of functions #77

Merged
merged 2 commits into from
Jan 6, 2024

Conversation

koddsson
Copy link
Member

@koddsson koddsson commented Jan 6, 2024

loupe currently doesn't differentiate between the different functions and it probably should.

See chaijs/chai#1566

@koddsson koddsson requested review from keithamus and 43081j January 6, 2024 09:23
@koddsson koddsson enabled auto-merge (squash) January 6, 2024 09:23
@koddsson koddsson mentioned this pull request Jan 6, 2024
src/function.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
@koddsson koddsson force-pushed the add-support-for-different-types-of-functions branch from e4b915e to 17dc89d Compare January 6, 2024 19:39
Copy link
Member

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@koddsson koddsson merged commit 9b8a6de into main Jan 6, 2024
6 checks passed
@koddsson koddsson deleted the add-support-for-different-types-of-functions branch January 6, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants