Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sinon 5 #120

Closed
westy92 opened this issue Mar 21, 2018 · 2 comments
Closed

Support sinon 5 #120

westy92 opened this issue Mar 21, 2018 · 2 comments

Comments

@westy92
Copy link

westy92 commented Mar 21, 2018

No description provided.

@kaiyoma
Copy link

kaiyoma commented Apr 30, 2018

I think this should be bumped up in priority because sinon 5.0.1 was just released. Now if I try to run the latest release of both packages, I get yarn check errors.

@voxpelli
Copy link

voxpelli commented May 7, 2018

What about not limiting the upper version but rather specify the minimum version of Sinon that is required? And only limit it when shown that a version can't be compatible with both an older and a newer version?

  • some docs on which versions sinon-chai is tested with.

This should also extend the test matrix: https://github.com/domenic/sinon-chai/blob/master/.travis.yml#L8

domenic pushed a commit that referenced this issue May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants