Add support for sinon v4 #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As you can see, the test suite fails on Sinon v4, so this is not mergeable. |
|
Yeah, I will investigate failing tests tomorrow, it was ok on local machine
…On Tue, 26 Sep 2017 at 16:52, Domenic Denicola ***@***.***> wrote:
As you can see
<https://travis-ci.org/domenic/sinon-chai/builds/279896519?utm_source=github_status&utm_medium=notification>,
the test suite fails on Sinon v4, so this is not mergeable.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#111 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABur3MVOwCajJcI883nY4U7bIbRE__-wks5smQGEgaJpZM4PkAYm>
.
|
Closed
|
Looks like another dependency ( |
westy92
approved these changes
Sep 27, 2017
|
I think it's a bug in npm and it was fixed in 5.4.2: https://github.com/npm/npm/releases/tag/v5.4.2 |
|
steps: $ node --version
v8.5.0
$ npm --version
5.3.0
npm install
mocha — ok
npm install sinon@^3.0.0
mocha — fail
Error: Cannot find module 'nise'
Because in nise package.json there is no more `main` field |
Yeti-or
force-pushed
the
yeti-or.update_sinon_to_4.0.0
branch
5 times, most recently
from
a3537f3
to
89ab325
Compare
|
@domenic tests are green, so is it mergeable now ? |
|
@Yeti-or it could be related to sinonjs/nise#10 |
|
Nice hack. Can we remove lolex too then? |
Yeti-or
force-pushed
the
yeti-or.update_sinon_to_4.0.0
branch
from
89ab325
to
5368706
Compare
|
@domenic yes we can |
fatso83
added a commit
to fatso83/sinon
that referenced
this pull request
Oct 4, 2017
franck-romano
pushed a commit
to franck-romano/sinon
that referenced
this pull request
Oct 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.