fix: favor extended array toStringTag where available

chaijs · Apr 18, 2017 · c0c5ed4 · c0c5ed4
1 parent 9af1fee
commit c0c5ed4
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/index.js b/index.js
@@ -91,7 +91,10 @@ module.exports = function typeDetect(obj) {
    * Post:
    *   array literal      x 22,479,650 ops/sec ±0.96% (81 runs sampled)
    */
-  if (Array.isArray(obj)) {
+  if (
+    Array.isArray(obj) &&
+    (symbolToStringTagExists === false || typeof obj[Symbol.toStringTag] === 'undefined')
+  ) {
     return 'Array';
   }
 

diff --git a/test/index.js b/test/index.js
@@ -258,7 +258,6 @@ describe('Generic', function () {
       Object.prototype.toString = originalObjectToString; // eslint-disable-line no-extend-native
     });
 
-
     it('plain object', function () {
       var obj = {};
       obj[Symbol.toStringTag] = function () {
@@ -267,6 +266,14 @@ describe('Generic', function () {
       assert(type(obj) === 'Foo', 'type(obj) === "Foo"');
     });
 
+    it('array', function () {
+      var arr = [];
+      arr[Symbol.toStringTag] = function () {
+        return 'Foo';
+      };
+      assert(type(arr) === 'Foo', 'type(arr) === "Foo"');
+    });
+
   });
 
 });