Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KEPLR-503] Add Reject bottom button on user interaction required page #1232

Merged
merged 8 commits into from
Nov 11, 2024

Conversation

piatoss3612
Copy link
Collaborator

@piatoss3612 piatoss3612 commented Nov 5, 2024

Changes

  1. useInteractionInfo Hook

    • Fixed issue where unmounting components rejected all requests (e.g., back button, macOS gestures).
    • Separated cleanup for window closure and component unmount to handle requests sequentially.
  2. HeaderLayout

    • Updated to accept multiple bottom buttons via an array.
    • Explicitly set button types to prevent accidental form submissions when using onSubmit.
  3. Button Left Style

    • Applied transparent when the icon’s fill is none to remove white background.
  4. Reject Button Handling

    • Processes the next request if available.
    • If no pending requests:
      • External Interaction: Handled the same as approve.
      • Internal Interaction: Rejects without navigating away, allowing back or home navigation.
      • Unexpected Situations: Redirects to home using replace.

apps/extension/src/components/button/styles.ts Outdated Show resolved Hide resolved
apps/extension/src/pages/sign/ethereum/view.tsx Outdated Show resolved Hide resolved
@Thunnini Thunnini marked this pull request as ready for review November 11, 2024 12:24
@Thunnini Thunnini merged commit 411bc63 into develop Nov 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants