Feat/sync new from now (subrepo) #232

Kukks · 2021-11-08T17:06:38Z

No description provided.

DanGould · 2021-11-08T17:07:45Z

Missing ChaincaseBitcoinStore.cs(26, 30): [CS0506] 'ChaincaseBitcoinStore.InitializeAsync()': cannot override inherited member 'BitcoinStore.InitializeAsync()' because it is not marked virtual, abstract, or override
ChaincaseClient.cs(48, 60): [CS0246] The type or namespace name 'DeviceToken' could not be found (are you missing a using directive or an assembly reference?)

DanGould · 2021-11-08T17:08:29Z

those changes are at get-latest-mature-header

subrepo: subdir: "WalletWasabi.SDK" merged: "451508d90" upstream: origin: "https://github.com/chaincase-app/WalletWasabi.Standard" branch: "sdk" commit: "b135c86ff" git-subrepo: version: "0.4.3" origin: "???" commit: "???"

DanGould · 2021-11-09T02:42:25Z

😮‍💨 nice, this now includes all the subrepo changes w/o the submodule dep. iOS crashes cause there are permission changes to the tor cookie file in #197 that aren't included here but I think you can check sync-from-now on ssb

docker fails in test cause we're using WalletWasabi.SDK folder now

Chaincase.Common/Services/ChaincaseClient.cs

DanGould

rip out load from blockheight beforehand is my main request

Chaincase.UI/Components/Status.razor

Chaincase.UI/Pages/LoadWalletPage.razor

Chaincase.UI/Pages/LoginPage.razor

Chaincase.UI/Pages/NewPasswordPage.razor

Chaincase.UI/ViewModels/NewPasswordViewModel.cs

subrepo: subdir: "WalletWasabi.SDK" merged: "704e77c81" upstream: origin: "https://github.com/chaincase-app/WalletWasabi.Standard" branch: "sdk" commit: "7c2ebfacd" git-subrepo: version: "0.4.3" origin: "???" commit: "???"

DanGould · 2021-11-09T20:38:43Z

WalletWasabi.SDK/WalletWasabi/Services/WasabiSynchronizer.cs

-			WasabiClient = null;
-
+			// WasabiClient?.Dispose();
+			// WasabiClient = null;


What's this for? I don't think we can maintain this in memory when iOS goes to sleep

DanGould · 2021-11-09T20:45:58Z

Chaincase.Common/Config.cs

@@ -34,7 +34,12 @@ public class Config : ConfigBase

        [JsonProperty(PropertyName = "Network")]
        [JsonConverter(typeof(NetworkJsonConverter))]
-        public NBitcoin.Network Network { get; internal set; } = NBitcoin.Network.Main;
+        #if DEBUG


delett this

DanGould · 2021-11-09T20:47:12Z

Chaincase.UI/Components/Status.razor

@@ -1,5 +1,5 @@
 @inject StatusViewModel StatusViewModel
-
+@using WalletWasabi.Stores


rm, unused afaik

DanGould · 2021-11-09T20:49:06Z

WalletWasabi.SDK/WalletWasabi.Backend/Global.cs

@@ -160,6 +175,15 @@ private async Task AssertRpcNodeFullyInitializedAsync()
 						}
 						Logger.LogInfo($"Generated 101 block on {Network.RegTest}. Number of blocks {blocks}.");
 					}
+					//101 blocks is fine, but let's spice things up in regtest for better sync tests


where is the aforementioned spice at?

…incase into kukks/feat/sync-new-from-now

When I wrote this test the python script used 600,000 iterations but in practice we use 200,000, so I updated the ciphertext to reflect 200,000 iterations

DanGould · 2021-11-13T19:23:40Z

Even when running the backend regtest docker-compose the backend NotificationTests & SyncWalletFromRecentBlock fail cause they seemingly can't connect to the BackendEndPoint = $"http://localhost:{new Random().Next(37130, 38000)}/"; (connection refused)

additionally, the tokens tableattempts to be crated multiple times and fails

bitcoind_1  | 2021-11-13T19:14:38Z FlushStateToDisk: write coins cache to disk (101 coins, 14kB) completed (0.00s)
postgres_1  | 2021-11-13 19:16:38.934 UTC [63] ERROR:  relation "Tokens" already exists
postgres_1  | 2021-11-13 19:16:38.934 UTC [63] STATEMENT:  CREATE TABLE "Tokens" (
postgres_1  | 	    "Token" text NOT NULL,
postgres_1  | 	    "Type" integer NOT NULL,
postgres_1  | 	    "Status" integer NOT NULL,
postgres_1  | 	    CONSTRAINT "PK_Tokens" PRIMARY KEY ("Token")
postgres_1  | 	)

regardless of the purpose of the test and the state of the ViewModel, what's rendered is not the same as my experience nor the state of the SendViewModel. The binding or test need to be fundamentally reconsidered

subrepo: subdir: "WalletWasabi.SDK" merged: "e5404fab0" upstream: origin: "https://github.com/chaincase-app/WalletWasabi.Standard" branch: "sdk" commit: "7c2ebfacd" git-subrepo: version: "0.4.3" origin: "???" commit: "???"

DanGould and others added 6 commits November 8, 2021 17:58

sync from recent height on new wallet

d417b34

Make it work

b4214d1

make tests run docker compose of backend

d588f83

dont force users to go through max pain when not needed

9b3fef3

more general CI

8c0ba61

move tests to chaincase

ff53475

DanGould added 2 commits November 8, 2021 21:23

rm submodule

1f15e96

git subrepo commit (merge) WalletWasabi.SDK

529a61c

subrepo: subdir: "WalletWasabi.SDK" merged: "451508d90" upstream: origin: "https://github.com/chaincase-app/WalletWasabi.Standard" branch: "sdk" commit: "b135c86ff" git-subrepo: version: "0.4.3" origin: "???" commit: "???"

link sdk deps

50a3d5e

DanGould changed the title ~~Feat/sync new from now~~ Feat/sync new from now (subrepo) Nov 9, 2021

DanGould reviewed Nov 9, 2021

View reviewed changes

Chaincase.Common/Services/ChaincaseClient.cs Outdated Show resolved Hide resolved

DanGould suggested changes Nov 9, 2021

View reviewed changes

DanGould and others added 5 commits November 9, 2021 15:21

Merge branch 'master' into kukks/feat/sync-new-from-now

4317bcb

fix test

0097272

fix stuff subrepo change

11574fc

Apply suggestions from review

cbe45bc

remove module

2eae28c

DanGould force-pushed the feat/sync-new-from-now branch from b2f1661 to 2eae28c Compare November 9, 2021 20:25

DanGould and others added 5 commits November 9, 2021 16:12

git subrepo commit (merge) WalletWasabi.SDK

7e049d7

subrepo: subdir: "WalletWasabi.SDK" merged: "704e77c81" upstream: origin: "https://github.com/chaincase-app/WalletWasabi.Standard" branch: "sdk" commit: "7c2ebfacd" git-subrepo: version: "0.4.3" origin: "???" commit: "???"

merge sdk

e39cc08

rm RemoveToken test cause we don't

bedd19d

resolve merge

afccec3

Fixes and make playwright a local dotnet tool

57abcf5

Kukks requested a review from DanGould November 12, 2021 06:38

Kukks added 3 commits November 12, 2021 07:46

auto restore local tool for test

34bde86

try without no restore

8e84e61

Fix tests

d4d1ef6

fix tests

670d367

DanGould approved these changes Nov 12, 2021

View reviewed changes

Kukks and others added 6 commits November 12, 2021 15:32

remove Delete tokens endpoint and fix challenge detection for hashcash

d0d07ea

Main net default

dc476ec

use ChaincaseClient for notification reg

9d1782d

Merge branch 'feat/sync-new-from-now' of https://github.com/Kukks/cha…

12c9c14

…incase into kukks/feat/sync-new-from-now

rm chaincase test from wasabi

1719a18

CanDecryptCiphertextFromPython

9e91cdd

When I wrote this test the python script used 600,000 iterations but in practice we use 200,000, so I updated the ciphertext to reflect 200,000 iterations

DanGould and others added 5 commits November 13, 2021 14:25

reconsider broken SnedButtonValidation test

b1ae212

regardless of the purpose of the test and the state of the ViewModel, what's rendered is not the same as my experience nor the state of the SendViewModel. The binding or test need to be fundamentally reconsidered

Fix tests

71fe6bb

git subrepo commit (merge) WalletWasabi.SDK

e831b67

subrepo: subdir: "WalletWasabi.SDK" merged: "e5404fab0" upstream: origin: "https://github.com/chaincase-app/WalletWasabi.Standard" branch: "sdk" commit: "7c2ebfacd" git-subrepo: version: "0.4.3" origin: "???" commit: "???"

Add subrepo to sln file

e39488c

Remove logs

be0848a

Kukks force-pushed the feat/sync-new-from-now branch from 5bd6e91 to be0848a Compare November 16, 2021 09:59

Kukks merged commit 28ea033 into chaincase-app:master Nov 22, 2021

Kukks mentioned this pull request Nov 22, 2021

sync from recent height on new wallet #196

Closed

DanGould mentioned this pull request Apr 27, 2022

Overhaul Sync + Status to be ✨ Delightful ✨ #230

Closed

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/sync new from now (subrepo) #232

Feat/sync new from now (subrepo) #232

Kukks commented Nov 8, 2021

DanGould commented Nov 8, 2021

DanGould commented Nov 8, 2021

DanGould commented Nov 9, 2021 •

edited

Loading

DanGould left a comment

DanGould Nov 9, 2021

DanGould Nov 9, 2021

DanGould Nov 9, 2021

DanGould Nov 9, 2021

DanGould commented Nov 13, 2021

		@@ -1,5 +1,5 @@
		@inject StatusViewModel StatusViewModel

		@using WalletWasabi.Stores

Feat/sync new from now (subrepo) #232

Feat/sync new from now (subrepo) #232

Conversation

Kukks commented Nov 8, 2021

DanGould commented Nov 8, 2021

DanGould commented Nov 8, 2021

DanGould commented Nov 9, 2021 • edited Loading

DanGould left a comment

Choose a reason for hiding this comment

DanGould Nov 9, 2021

Choose a reason for hiding this comment

DanGould Nov 9, 2021

Choose a reason for hiding this comment

DanGould Nov 9, 2021

Choose a reason for hiding this comment

DanGould Nov 9, 2021

Choose a reason for hiding this comment

DanGould commented Nov 13, 2021

DanGould commented Nov 9, 2021 •

edited

Loading