Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "make check" target to build and run tests #37

Merged
merged 1 commit into from
May 13, 2020

Conversation

ryanofsky
Copy link
Collaborator

fanquake reported #36 that instructions for running tests in the README are wrong, and there isn't a convenient way to build and run tests, so this PR adds a "make check" custom target to make it more straightforward.

The new "make check" target builds and runs all available tests, while the previous "make test" target (provided by CTest) only runs existing test binaries without building anything.

This PR also:

  • Moves all test code and build rules to a new test/ subdirectory to separate test code from non-test code
  • Adds a new "make tests" target used internally by "make check" to build tests without running them

CTest already provides a "make test" target, but this only runs previously
built tests.

Also in this commit:

- Move all test code and build rules to a new test/ subdirectory to separate
  test code from non-test code
- Add a new "make tests" target used internally by "make check" to build tests
  without running them
@fanquake
Copy link
Contributor

Thanks. Tested 0378353 and that running make check works for me.

@ryanofsky ryanofsky merged commit 9f5b835 into chaincodelabs:master May 13, 2020
ryanofsky added a commit to ryanofsky/bitcoin that referenced this pull request Dec 8, 2020
Fix "Disable GCC suggest-override warnings for proxy clients" chaincodelabs/libmultiprocess#40 is needed to prevent cirrus GCC failure https://cirrus-ci.com/task/6000489311502336?command=ci#L4294

This also includes other recent changes

chaincodelabs/libmultiprocess#35 Fix README.md markdown bitcoin#35
chaincodelabs/libmultiprocess#37 Add "make check" target to build and run tests bitcoin#37
chaincodelabs/libmultiprocess#38 Add "extends" inherited method support bitcoin#38
ryanofsky added a commit to ryanofsky/bitcoin that referenced this pull request Dec 11, 2020
Fix "Disable GCC suggest-override warnings for proxy clients" chaincodelabs/libmultiprocess#40 is needed to prevent cirrus GCC failure https://cirrus-ci.com/task/6000489311502336?command=ci#L4294

This also includes other recent changes

chaincodelabs/libmultiprocess#35 Fix README.md markdown bitcoin#35
chaincodelabs/libmultiprocess#37 Add "make check" target to build and run tests bitcoin#37
chaincodelabs/libmultiprocess#38 Add "extends" inherited method support bitcoin#38
ryanofsky added a commit to ryanofsky/bitcoin that referenced this pull request Dec 11, 2020
Fix "Disable GCC suggest-override warnings for proxy clients" chaincodelabs/libmultiprocess#40 is needed to prevent cirrus GCC failure https://cirrus-ci.com/task/6000489311502336?command=ci#L4294

This also includes other recent changes

chaincodelabs/libmultiprocess#35 Fix README.md markdown
chaincodelabs/libmultiprocess#37 Add "make check" target to build and run tests
chaincodelabs/libmultiprocess#38 Add "extends" inherited method support
ryanofsky added a commit to ryanofsky/bitcoin that referenced this pull request Dec 18, 2020
Fix "Disable GCC suggest-override warnings for proxy clients" chaincodelabs/libmultiprocess#40 is needed to prevent cirrus GCC failure https://cirrus-ci.com/task/6000489311502336?command=ci#L4294

This also includes other recent changes

chaincodelabs/libmultiprocess#35 Fix README.md markdown
chaincodelabs/libmultiprocess#37 Add "make check" target to build and run tests
chaincodelabs/libmultiprocess#38 Add "extends" inherited method support
ryanofsky added a commit to ryanofsky/bitcoin that referenced this pull request Dec 18, 2020
Fix "Disable GCC suggest-override warnings for proxy clients" chaincodelabs/libmultiprocess#40 is needed to prevent cirrus GCC failure https://cirrus-ci.com/task/6000489311502336?command=ci#L4294

This also includes other recent changes

chaincodelabs/libmultiprocess#35 Fix README.md markdown
chaincodelabs/libmultiprocess#37 Add "make check" target to build and run tests
chaincodelabs/libmultiprocess#38 Add "extends" inherited method support
chaincodelabs/libmultiprocess#41 Avoid depending on argument default constructors
ryanofsky added a commit to ryanofsky/bitcoin that referenced this pull request Jan 28, 2021
Fix "Disable GCC suggest-override warnings for proxy clients" chaincodelabs/libmultiprocess#40 is needed to prevent cirrus GCC failure https://cirrus-ci.com/task/6000489311502336?command=ci#L4294

This also includes other recent changes

chaincodelabs/libmultiprocess#35 Fix README.md markdown
chaincodelabs/libmultiprocess#37 Add "make check" target to build and run tests
chaincodelabs/libmultiprocess#38 Add "extends" inherited method support
chaincodelabs/libmultiprocess#41 Avoid depending on argument default constructors
chaincodelabs/libmultiprocess#42 Support attaching custom cleanup functions to proxy client and server classes
chaincodelabs/libmultiprocess#43 Drop hardcoded #include lines in generated files
ryanofsky added a commit to ryanofsky/bitcoin that referenced this pull request Jan 28, 2021
Fix "Disable GCC suggest-override warnings for proxy clients" chaincodelabs/libmultiprocess#40 is needed to prevent cirrus GCC failure https://cirrus-ci.com/task/6000489311502336?command=ci#L4294

This also includes other recent changes

chaincodelabs/libmultiprocess#35 Fix README.md markdown
chaincodelabs/libmultiprocess#37 Add "make check" target to build and run tests
chaincodelabs/libmultiprocess#38 Add "extends" inherited method support
chaincodelabs/libmultiprocess#41 Avoid depending on argument default constructors
ryanofsky added a commit to ryanofsky/bitcoin that referenced this pull request Mar 4, 2021
Fix "Disable GCC suggest-override warnings for proxy clients" chaincodelabs/libmultiprocess#40 is needed to prevent cirrus GCC failure https://cirrus-ci.com/task/6000489311502336?command=ci#L4294

This also includes other recent changes

chaincodelabs/libmultiprocess#35 Fix README.md markdown
chaincodelabs/libmultiprocess#37 Add "make check" target to build and run tests
chaincodelabs/libmultiprocess#38 Add "extends" inherited method support
chaincodelabs/libmultiprocess#41 Avoid depending on argument default constructors
chaincodelabs/libmultiprocess#42 Support attaching custom cleanup functions to proxy client and server classes
chaincodelabs/libmultiprocess#43 Drop hardcoded #include lines in generated files
ryanofsky added a commit to ryanofsky/bitcoin that referenced this pull request Mar 4, 2021
Fix "Disable GCC suggest-override warnings for proxy clients" chaincodelabs/libmultiprocess#40 is needed to prevent cirrus GCC failure https://cirrus-ci.com/task/6000489311502336?command=ci#L4294

This also includes other recent changes

chaincodelabs/libmultiprocess#35 Fix README.md markdown
chaincodelabs/libmultiprocess#37 Add "make check" target to build and run tests
chaincodelabs/libmultiprocess#38 Add "extends" inherited method support
chaincodelabs/libmultiprocess#41 Avoid depending on argument default constructors
chaincodelabs/libmultiprocess#42 Support attaching custom cleanup functions to proxy client and server classes
chaincodelabs/libmultiprocess#43 Drop hardcoded #include lines in generated files
ryanofsky added a commit to ryanofsky/bitcoin that referenced this pull request Mar 4, 2021
Update libmultiprocess library

Fix "Disable GCC suggest-override warnings for proxy clients" chaincodelabs/libmultiprocess#40 is needed to prevent cirrus GCC failure https://cirrus-ci.com/task/6000489311502336?command=ci#L4294

This also includes other recent changes

chaincodelabs/libmultiprocess#35 Fix README.md markdown
chaincodelabs/libmultiprocess#37 Add "make check" target to build and run tests
chaincodelabs/libmultiprocess#38 Add "extends" inherited method support
chaincodelabs/libmultiprocess#41 Avoid depending on argument default constructors
chaincodelabs/libmultiprocess#42 Support attaching custom cleanup functions to proxy client and server classes
chaincodelabs/libmultiprocess#43 Drop hardcoded #include lines in generated files
ryanofsky added a commit to ryanofsky/bitcoin that referenced this pull request Mar 17, 2021
Update libmultiprocess library

Fix "Disable GCC suggest-override warnings for proxy clients" chaincodelabs/libmultiprocess#40 is needed to prevent cirrus GCC failure https://cirrus-ci.com/task/6000489311502336?command=ci#L4294

This also includes other recent changes

chaincodelabs/libmultiprocess#35 Fix README.md markdown
chaincodelabs/libmultiprocess#37 Add "make check" target to build and run tests
chaincodelabs/libmultiprocess#38 Add "extends" inherited method support
chaincodelabs/libmultiprocess#41 Avoid depending on argument default constructors
chaincodelabs/libmultiprocess#42 Support attaching custom cleanup functions to proxy client and server classes
chaincodelabs/libmultiprocess#43 Drop hardcoded #include lines in generated files
ryanofsky added a commit to ryanofsky/bitcoin that referenced this pull request Mar 17, 2021
Fix "Disable GCC suggest-override warnings for proxy clients" chaincodelabs/libmultiprocess#40 is needed to prevent cirrus GCC failure https://cirrus-ci.com/task/6000489311502336?command=ci#L4294

This also includes other recent changes

chaincodelabs/libmultiprocess#35 Fix README.md markdown
chaincodelabs/libmultiprocess#37 Add "make check" target to build and run tests
chaincodelabs/libmultiprocess#38 Add "extends" inherited method support
chaincodelabs/libmultiprocess#41 Avoid depending on argument default constructors
chaincodelabs/libmultiprocess#42 Support attaching custom cleanup functions to proxy client and server classes
chaincodelabs/libmultiprocess#43 Drop hardcoded #include lines in generated files
ryanofsky added a commit to ryanofsky/bitcoin that referenced this pull request Mar 17, 2021
Fix "Disable GCC suggest-override warnings for proxy clients" chaincodelabs/libmultiprocess#40 is needed to prevent cirrus GCC failure https://cirrus-ci.com/task/6000489311502336?command=ci#L4294

This also includes other recent changes

chaincodelabs/libmultiprocess#35 Fix README.md markdown
chaincodelabs/libmultiprocess#37 Add "make check" target to build and run tests
chaincodelabs/libmultiprocess#38 Add "extends" inherited method support
chaincodelabs/libmultiprocess#41 Avoid depending on argument default constructors
chaincodelabs/libmultiprocess#42 Support attaching custom cleanup functions to proxy client and server classes
chaincodelabs/libmultiprocess#43 Drop hardcoded #include lines in generated files
ryanofsky added a commit to ryanofsky/bitcoin that referenced this pull request Mar 30, 2021
Fix "Disable GCC suggest-override warnings for proxy clients" chaincodelabs/libmultiprocess#40 is needed to prevent cirrus GCC failure https://cirrus-ci.com/task/6000489311502336?command=ci#L4294

This also includes other recent changes

chaincodelabs/libmultiprocess#35 Fix README.md markdown
chaincodelabs/libmultiprocess#37 Add "make check" target to build and run tests
chaincodelabs/libmultiprocess#38 Add "extends" inherited method support
chaincodelabs/libmultiprocess#41 Avoid depending on argument default constructors
chaincodelabs/libmultiprocess#42 Support attaching custom cleanup functions to proxy client and server classes
chaincodelabs/libmultiprocess#43 Drop hardcoded #include lines in generated files
ryanofsky added a commit to ryanofsky/bitcoin that referenced this pull request Mar 30, 2021
Fix "Disable GCC suggest-override warnings for proxy clients" chaincodelabs/libmultiprocess#40 is needed to prevent cirrus GCC failure https://cirrus-ci.com/task/6000489311502336?command=ci#L4294

This also includes other recent changes

chaincodelabs/libmultiprocess#35 Fix README.md markdown
chaincodelabs/libmultiprocess#37 Add "make check" target to build and run tests
chaincodelabs/libmultiprocess#38 Add "extends" inherited method support
chaincodelabs/libmultiprocess#41 Avoid depending on argument default constructors
chaincodelabs/libmultiprocess#42 Support attaching custom cleanup functions to proxy client and server classes
chaincodelabs/libmultiprocess#43 Drop hardcoded #include lines in generated files
ariard pushed a commit to ariard/bitcoin that referenced this pull request Apr 6, 2021
Fix "Disable GCC suggest-override warnings for proxy clients" chaincodelabs/libmultiprocess#40 is needed to prevent cirrus GCC failure https://cirrus-ci.com/task/6000489311502336?command=ci#L4294

This also includes other recent changes

chaincodelabs/libmultiprocess#35 Fix README.md markdown
chaincodelabs/libmultiprocess#37 Add "make check" target to build and run tests
chaincodelabs/libmultiprocess#38 Add "extends" inherited method support
chaincodelabs/libmultiprocess#41 Avoid depending on argument default constructors
chaincodelabs/libmultiprocess#42 Support attaching custom cleanup functions to proxy client and server classes
chaincodelabs/libmultiprocess#43 Drop hardcoded #include lines in generated files
ryanofsky added a commit to ryanofsky/bitcoin that referenced this pull request Apr 23, 2021
Fix "Disable GCC suggest-override warnings for proxy clients" chaincodelabs/libmultiprocess#40 is needed to prevent cirrus GCC failure https://cirrus-ci.com/task/6000489311502336?command=ci#L4294

This also includes other recent changes

chaincodelabs/libmultiprocess#35 Fix README.md markdown
chaincodelabs/libmultiprocess#37 Add "make check" target to build and run tests
chaincodelabs/libmultiprocess#38 Add "extends" inherited method support
chaincodelabs/libmultiprocess#41 Avoid depending on argument default constructors
chaincodelabs/libmultiprocess#42 Support attaching custom cleanup functions to proxy client and server classes
chaincodelabs/libmultiprocess#43 Drop hardcoded #include lines in generated files
ryanofsky added a commit to ryanofsky/bitcoin that referenced this pull request Apr 23, 2021
Fix "Disable GCC suggest-override warnings for proxy clients" chaincodelabs/libmultiprocess#40 is needed to prevent cirrus GCC failure https://cirrus-ci.com/task/6000489311502336?command=ci#L4294

This also includes other recent changes

chaincodelabs/libmultiprocess#35 Fix README.md markdown
chaincodelabs/libmultiprocess#37 Add "make check" target to build and run tests
chaincodelabs/libmultiprocess#38 Add "extends" inherited method support
chaincodelabs/libmultiprocess#41 Avoid depending on argument default constructors
chaincodelabs/libmultiprocess#42 Support attaching custom cleanup functions to proxy client and server classes
chaincodelabs/libmultiprocess#43 Drop hardcoded #include lines in generated files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants