Skip to content
This repository has been archived by the owner on Jul 2, 2021. It is now read-only.

Improve random_rotate #684

Closed
nattochaduke opened this issue Sep 3, 2018 · 2 comments
Closed

Improve random_rotate #684

nattochaduke opened this issue Sep 3, 2018 · 2 comments
Labels

Comments

@nattochaduke
Copy link

For now, chainercv.transforms.random_rotate rotates image by right angle (one of 0, 90, 180, 270 degrees).
However I believe that it is convenient that the degree of rotation is sampled from more fine distribution {i | -180 <= i <= 180} and the range of distribution can be specified, like pytorch's random_rotate.
So I propose to add arguments that enables this feature to random_rotate or to add another function to chainercv.transforms.

@yuyu2172
Copy link
Member

Thanks for your suggestion.
I see both the current implementation and what you proposed convenient, so I should probably have two functions for them.
Thinking about it, I should have probably named the function as random_rot90.

@knorth55
Copy link
Contributor

this is implemented in #690

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants